fix: retry on 401#209
Merged
Merged
Conversation
cjquines
approved these changes
Mar 12, 2026
Contributor
cjquines
left a comment
cjquines
left a comment
There was a problem hiding this comment.
hmmm sure i guess? is this better than making certain 401s retriable via custom code? mostly wondering because we do have special retry magic logic (exponential backoff and jitter, right)
Member
Author
|
I think it's a little weird to build into the SDK itself given that this is a GItHub OIDC issue, which isn't a typical auth method for our API. |
Contributor
|
true true true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I strongly suspect OIDC token decode is just failing transiently sometimes, so I believe retries will help