fix: catch guesser errors#211
Merged
Merged
Conversation
cjquines
reviewed
Mar 16, 2026
| )[0]?.content; | ||
| } | ||
| } catch (e) { | ||
| logger.warn("Error guessing config, continuing anyways", e); |
Contributor
There was a problem hiding this comment.
nit: { error: e } or { err: e }, because pino has special handling for errors in that case i thiiiiiink
Contributor
There was a problem hiding this comment.
ah wait wrong repo. nvm then
cjquines
approved these changes
Mar 16, 2026
bzwheeler
pushed a commit
to closeio/stainless-upload-openapi-spec-action
that referenced
this pull request
Apr 2, 2026
Co-authored-by: meorphis <eric@stainless.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
making a change on our server side to be more aggressive about throwing rather than failing silently - but we can still fail silently on the client, since guesser errors shouldn't block the user