Skip to content

fix: catch guesser errors #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meorphis merged 1 commit into from
Mar 16, 2026
Merged

fix: catch guesser errors #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions dist/build.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 18 additions & 14 deletions dist/merge.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 18 additions & 14 deletions dist/preview.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 18 additions & 14 deletions src/runBuilds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,20 +121,24 @@ export async function* runBuilds({
logger.debug("Guessing config before branch reset");
// If the `branch` already exists, we should guess against it, in case
// there were changes made via the studio.
if (hasBranch) {
configContent = Object.values(
await stainless.projects.configs.guess({
branch,
spec: oasContent!,
}),
)[0]?.content;
} else {
configContent = Object.values(
await stainless.projects.configs.guess({
branch: branchFrom,
spec: oasContent!,
}),
)[0]?.content;
try {
if (hasBranch) {
configContent = Object.values(
await stainless.projects.configs.guess({
branch,
spec: oasContent!,
}),
)[0]?.content;
} else {
configContent = Object.values(
await stainless.projects.configs.guess({
branch: branchFrom,
spec: oasContent!,
}),
)[0]?.content;
}
} catch (e) {
logger.warn("Error guessing config, continuing anyways", e);
Copy link
Copy Markdown
Contributor

@cjquines cjquines Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: { error: e } or { err: e }, because pino has special handling for errors in that case i thiiiiiink

Copy link
Copy Markdown
Contributor

@cjquines cjquines Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah wait wrong repo. nvm then

}
} else if (hasBranch && hasBaseBranch) {
logger.debug("Computing config patch before branch reset");
Expand Down