Commit 976a223
committed
fix(db): strip
CI failed again with the same `RangeError: The supplied SQL string
contains no statements` from yesterday's lesson — I introduced a `;`
inside the freshly-rewritten recipe_recency DDL block comment when
applying CodeRabbit nitpick #2 (the lazy-on-read prose fix).
Two changes:
1. Replaced "(recordRecipeRun DELETEs stale rows before its upsert);
reads stay pure." with em-dash to drop the inner `;`. (Same fix
shape as 649f7d2 from the previous round.)
2. **Added a regression guard** in `src/db.test.ts` that splits the
`createTables()` template on `;` and asserts no fragment is pure
`--` comments. Hitting this lesson twice in one PR is the trigger
the existing entry in `.agents/lessons.md` flagged as "candidate
roadmap item." Test runs in `bun test` (which Bun's `bun:sqlite`
masks), so it catches the regression locally before CI burns a
cycle.
887 → 888 tests; CI's `node dist/index.mjs --full` smoke verified
locally before push.; from -- comment + add regression guard1 parent 4a82bf7 commit 976a223
2 files changed
Lines changed: 33 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
2 | 4 | | |
3 | 5 | | |
4 | 6 | | |
| |||
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
21 | 52 | | |
22 | 53 | | |
23 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
203 | | - | |
| 202 | + | |
| 203 | + | |
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| |||
0 commit comments