feat(index): unresolved calls staging (SCHEMA 36)#162
Merged
Conversation
Add SCHEMA_VERSION 36, call-resolver pass after bindings, incremental scoped re-resolve, and unresolved-call-sites / call-resolution-stats recipes.
🦋 Changeset detectedLatest commit: 8d5dd13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reached
More reviews will be available in 14 minutes and 55 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (67)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use expandHeritageResolveScope for incremental call resolve, include all --files paths even when hash-unchanged, global unresolved_calls_residual meta, skip method-call false binds, resolve after deletion-only incremental, add changeset.
Add substrate pin-down goldens, index-table-stats aggregate, coverage-matrix guard, run-index call/deletion integration tests, and expanded agent-eval probes. Document the harness map in docs/testing-coverage.md.
Add fixtures/README.md, CAPABILITIES.json, and in-repo-test-bench plan so CI validates Codemap without external CODEMAP_ROOT. Bench corpus stays at fixtures/minimal; --corpus bench aliases minimal. Add method-call bench slice and golden; extend coverage-matrix guard for manifest files.
Add shop-symbols-recipe golden, cmd-test-bench-e2e for show/snippet/impact/ validate/SARIF on fixtures/minimal, and an agent-eval probe. Mark plan phases 2–3 largely complete in in-repo-test-bench.md.
Expand probes to 18 golden-backed scenarios, add capability-probes.test.mjs guard, and fix live MCP smoke to assert find-call-sites by id not index.
Treat re-exported/same-file without symbol_id as resolved; document method calls in call-resolution-stats; restore bindings-engine comments moved to loadBindingIndexContext.
Align P2 backlog with shipped plans (PR #162); Phase 4 bench scale stays in plan only.
Delete plan file per docs-governance; point roadmap and callback-dispatch deps at architecture.md (#162).
Align architecture with deletion-only resolve scope and method-call NULL kinds; fix testing-coverage paths and agent-eval probe wording; sync CAPABILITIES.json substrate scenario ids with testing-coverage table.
Per docs/README Rule 6: remove hardcoded recipe/scenario/probe counts; point schema version at src/db.ts; fix agent-eval and substrate-extraction stale wording; label historical 3-probe benchmark sample.
Remove shipped P2 backlog lines; add unresolved_calls glossary entries; testing-coverage cross-ref in docs/README; bench tier points at shipped docs.
Add calls/coverage to SUBSTRATE_SCENARIO_BY_TABLE; fix glossary architecture anchor; clarify CONTRIBUTING guard scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-phase call resolution (SCHEMA 36) plus in-repo test bench hardening — merged as one squash commit (
6e50d77).Index — call resolution staging
SCHEMA_VERSION36:unresolved_callsqueue,calls.callee_symbol_id/callee_resolution_kindresolveCalls()insrc/application/call-resolver.tsafter bindings; reusesloadBindingIndexContext/resolveNameAtSiteexpandHeritageResolveScope(changed/requested/deleted paths); deletion-only path inrun-index.tsis_method_call) deferred — not queued,callee_*stay NULLunresolved-call-sites,call-resolution-statsunresolved_callsrebuild on upgrade)Canonical docs:
architecture.md(calls,unresolved_calls),glossary.md. Shipped plan retired per docs-governance (nodocs/plans/unresolved-calls-staging.md).Test bench (no external
CODEMAP_ROOT)fixtures/README.md,fixtures/CAPABILITIES.json,docs/testing-coverage.mdscripts/query-golden-coverage-matrix.test.mjscapability-probes.test.mjs;src/cli/cmd-test-bench-e2e.test.tsdocs/plans/in-repo-test-bench.md(Phases 1–3 shipped)Docs / hygiene
docs/README.mdRule 6)Out of scope (follow-up)
calls.provenanceheuristics) —docs/plans/callback-dispatch-synthesis.mdTest plan
bun run check(CI green on merge)bun test src/application/call-resolver.test.ts src/application/run-index.test.tsbun run test:golden+bun run test:scripts+bun run test:agent-evalmain,bun src/index.ts --full+codemap query --json --recipe call-resolution-stats