Skip to content

Commit b2b40da

Browse files
feat: add --ignore-annotation flag to override reloader.stakater.com/ignore
Allow users to customise the annotation key used to mark ConfigMaps and Secrets as ignored by Reloader, consistent with how every other annotation key is already overridable via a dedicated CLI flag. Changes: - internal/pkg/util/util.go: register --ignore-annotation persistent flag backed by options.IgnoreResourceAnnotation - deployments/kubernetes/chart/reloader/templates/deployment.yaml: pass --ignore-annotation when custom_annotations.ignore is set in Helm values - deployments/kubernetes/chart/reloader/values.yaml: document the new custom_annotations.ignore key in the example comment - README.md: add --ignore-annotation to the Annotation Key Overrides table and mention the flag alongside the Resource-Level Ignore Annotation section Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 90d5ec8 commit b2b40da

4 files changed

Lines changed: 7 additions & 0 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -440,6 +440,7 @@ These flags allow you to redefine annotation keys used in your workloads or reso
440440
| `--search-match-annotation` | Overrides `reloader.stakater.com/match` |
441441
| `--secret-annotation` | Overrides `secret.reloader.stakater.com/reload` |
442442
| `--configmap-annotation` | Overrides `configmap.reloader.stakater.com/reload` |
443+
| `--ignore-annotation` | Overrides `reloader.stakater.com/ignore` |
443444
| `--pause-deployment-annotation` | Overrides `deployment.reloader.stakater.com/pause-period` |
444445
| `--pause-deployment-time-annotation` | Overrides `deployment.reloader.stakater.com/paused-at` |
445446

deployments/kubernetes/chart/reloader/templates/deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,10 @@ spec:
277277
{{- if .Values.reloader.custom_annotations.match }}
278278
- "--search-match-annotation"
279279
- "{{ .Values.reloader.custom_annotations.match }}"
280+
{{- end }}
281+
{{- if .Values.reloader.custom_annotations.ignore }}
282+
- "--ignore-annotation"
283+
- "{{ .Values.reloader.custom_annotations.ignore }}"
280284
{{- end }}
281285
{{- if .Values.reloader.custom_annotations.pausePeriod }}
282286
- "--pause-deployment-annotation"

deployments/kubernetes/chart/reloader/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ reloader:
213213
# custom_annotations:
214214
# configmap: "my.company.com/configmap"
215215
# secret: "my.company.com/secret"
216+
# ignore: "my.company.com/reloader-ignore"
216217
custom_annotations: {}
217218

218219
serviceMonitor:

internal/pkg/util/util.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ func ConfigureReloaderFlags(cmd *cobra.Command) {
8484
cmd.PersistentFlags().StringVar(&options.ConfigmapUpdateOnChangeAnnotation, "configmap-annotation", "configmap.reloader.stakater.com/reload", "annotation to detect changes in configmaps, specified by name")
8585
cmd.PersistentFlags().StringVar(&options.SecretUpdateOnChangeAnnotation, "secret-annotation", "secret.reloader.stakater.com/reload", "annotation to detect changes in secrets, specified by name")
8686
cmd.PersistentFlags().StringVar(&options.ReloaderAutoAnnotation, "auto-annotation", "reloader.stakater.com/auto", "annotation to detect changes in secrets/configmaps")
87+
cmd.PersistentFlags().StringVar(&options.IgnoreResourceAnnotation, "ignore-annotation", "reloader.stakater.com/ignore", "annotation to ignore a resource when watching for changes in secrets/configmaps")
8788
cmd.PersistentFlags().StringVar(&options.ConfigmapReloaderAutoAnnotation, "configmap-auto-annotation", "configmap.reloader.stakater.com/auto", "annotation to detect changes in configmaps")
8889
cmd.PersistentFlags().StringVar(&options.SecretReloaderAutoAnnotation, "secret-auto-annotation", "secret.reloader.stakater.com/auto", "annotation to detect changes in secrets")
8990
cmd.PersistentFlags().StringVar(&options.AutoSearchAnnotation, "auto-search-annotation", "reloader.stakater.com/search", "annotation to detect changes in configmaps or secrets tagged with special match annotation")

0 commit comments

Comments
 (0)