added reloader-enterprise dependency#1186
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a Helm chart “v2” packaging flow and adds an optional reloader-enterprise subchart dependency to support an enterprise deployment mode alongside the operator.
Changes:
- Updates the Helm chart metadata (apiVersion v2, chart/app versions) and adds an
enterprisedependency gated byenterprise.enabled. - Adds Enterprise-mode values/docs plus a Helm-unittest suite for image override behavior.
- Adjusts GitHub Actions workflows for v2 image tagging and v2 chart release/publish tagging conventions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| deployments/kubernetes/chart/reloader/values.yaml | Adds enterprise-related global and subchart values; bumps default operator tag to v2.0.0. |
| deployments/kubernetes/chart/reloader/tests/enterprise_test.yaml | Adds a helm-unittest suite intended to validate image selection behavior. |
| deployments/kubernetes/chart/reloader/README.md | Documents “Enterprise mode” setup steps (enable subchart, set hosts, swap image, provide pull secret). |
| deployments/kubernetes/chart/reloader/Chart.yaml | Moves to Helm v2 chart format, renames chart to reloader-v2, and adds the reloader-enterprise dependency. |
| .github/workflows/release.yaml | Publishes a floating v2 image tag instead of latest for v2 releases. |
| .github/workflows/release-helm-chart.yaml | Updates chart release tagging/title to the new reloader-v2-chart-v* convention. |
| .github/workflows/push-helm-chart.yaml | Updates publish flow for reloader-v2, adds helm dependency build, and updates signing/tagging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SyedaFatimaKazmi
left a comment
SyedaFatimaKazmi
left a comment
Contributor
There was a problem hiding this comment.
also pls note that the private subchart gets bundled into the public chart package
if the enterprise chart templates are considered private IP, bundling them into a publicly pullable OCI artifact leaks them (only the images stay gated behind pull secrets)
please confirm this is intended
SyedaFatimaKazmi
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.