Add csi support#834
Merged
Merged
Conversation
Signed-off-by: Zanis <22601571+ZanisO@users.noreply.github.com>
Member
|
@ZanisO can you plz pull changes from main and update your PR? and also update the readme; we will start its review next week. |
Felix-Stakater
requested changes
Sep 12, 2025
Felix-Stakater
left a comment
Felix-Stakater
left a comment
Contributor
There was a problem hiding this comment.
Nice work, thank you!
Unless you respond we will fork this and take it over the finish line, sorry for the late review.
| var controllers []*controller.Controller | ||
| for k := range kube.ResourceMap { | ||
| if k == "secretproviderclasspodstatuses" { | ||
| if !options.EnableCSIIntegration { |
Contributor
There was a problem hiding this comment.
Do we want to invert the setting as to having it enabled if no option is supplied?
if options.DisableCSIIntegration
Member
|
@ZanisO are you around? |
Contributor
|
Taking this over, testing the feature and will merge it once tested properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've attempted to implement ability to watch SecretProviderClassPodStatus, discussed in #440