Skip to content

Update go version to 1.24.1 and update dependencies#882

Merged
karl-johan-grahn merged 3 commits into
masterfrom
feature/bump-go-1.24.1
Apr 2, 2025
Merged

Update go version to 1.24.1 and update dependencies#882
karl-johan-grahn merged 3 commits into
masterfrom
feature/bump-go-1.24.1

Conversation

@faizanahmad055

@faizanahmad055 faizanahmad055 commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@faizanahmad055
Update go version to 1.24.1
4e2e98d 
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
@faizanahmad055
Update dependencies
15221a8 
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
@IdanAdar IdanAdar mentioned this pull request Apr 1, 2025
Closed
@karl-johan-grahn

karl-johan-grahn commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

@bainsy88 you've been working on the UBI build files before, any idea why the UBI build fails with this change?

@bainsy88

bainsy88 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

@karl-johan-grahn This looks to be caused by the latest version of UBI moving /root/buildinfo/ to /usr/share/buildinfo. The internal project that this is based off no longer ships it in the image as it had no bearer on the vulnerability scanners we have tested against. So I am going to propose just removing it that from the files list

@bainsy88

bainsy88 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

I don't have access to write to this branch but the change would be to remove

root/buildinfo from both of the ubi-build-files-*.txt files

@IdanAdar

IdanAdar commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

@faizanahmad055 Can you add this change to your PR please?

@IdanAdar

IdanAdar commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

@karl-johan-grahn I don't know if @faizanahmad055 will update his PR or not, so here's a PR to remove the entries from the files @bainsy88 mentioned: #883

@karl-johan-grahn karl-johan-grahn merged commit 1a1260f into master Apr 2, 2025
@karl-johan-grahn karl-johan-grahn deleted the feature/bump-go-1.24.1 branch April 2, 2025 20:55
ChristianCiach pushed a commit to ChristianCiach/Reloader that referenced this pull request Jul 9, 2025
@faizanahmad055 @ChristianCiach
Update go version to 1.24.1 and update dependencies (stakater#882)
519ba58 
* Update go version to 1.24.1

Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>

* Update dependencies

Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>

---------

Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
pratikbin pushed a commit to NodeOps-app/Reloader that referenced this pull request Nov 13, 2025
@faizanahmad055
Update go version to 1.24.1 and update dependencies (stakater#882)
d82f9b2 
* Update go version to 1.24.1

Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>

* Update dependencies

Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>

---------

Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@karl-johan-grahn karl-johan-grahn karl-johan-grahn approved these changes
@IdanAdar IdanAdar IdanAdar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@faizanahmad055 @karl-johan-grahn @bainsy88 @IdanAdar