Skip to content

Improve profile tab accessibility#1615

Open
alan747271363-art wants to merge 1 commit into
stakwork:masterfrom
alan747271363-art:codex/workspace-tabs-a11y
Open

Improve profile tab accessibility#1615
alan747271363-art wants to merge 1 commit into
stakwork:masterfrom
alan747271363-art:codex/workspace-tabs-a11y

Conversation

@alan747271363-art
Copy link
Copy Markdown

Summary

  • add tablist/tab/tabpanel semantics to the profile tabs used for Workspaces, Badges, Bounties, and Assigned Bounties
  • link tabs and panels with stable ids via aria-controls/aria-labelledby
  • support Enter, Space, ArrowLeft, and ArrowRight keyboard interactions
  • add regression coverage for selected tab state, tab/panel linkage, and keyboard navigation

Closes #1234

Validation

  • npx.cmd --yes prettier@3.0.3 --config .prettierrc.json --check src/pages/people/tabs/index.tsx src/pages/people/tabs/tests/index.spec.tsx
  • cmd /c "set REACT_APP_IS_TEST=true&& set NODE_ENV=test&& node node_modules\jest\bin\jest.js --runTestsByPath src/pages/people/tabs/tests/index.spec.tsx --runInBand --no-coverage --silent --transformIgnorePatterns ./svg/"
  • npx.cmd eslint src/pages/people/tabs/index.tsx src/pages/people/tabs/tests/index.spec.tsx --max-warnings 100 (passes with one existing react-hooks/exhaustive-deps warning in index.tsx)
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility: "People" & "Bounties" Tabs pattern issues in Bounties Workspace pages

1 participant