Address review feedback: fix size/linewidth handling and pointrange defaults

- Error when both `size` and `linewidth` are supplied to resolve_linewidth()
- Add deprecation warning in ppc_rootogram() when `size` is used (previously
  controlled both point size and line width silently)
- Change default `size` for pointrange functions from 2.5 back to 1 (size=2.5
  with ggplot2 4.0's internal fatten=4 produced oversized points)
- Apply NEWS.md wording suggestions
- Remove duplicate @importFrom lifecycle line in bayesplot-package.R
- Update rootogram tests to use `linewidth` instead of deprecated `size`
- Regenerate vdiffr snapshots for updated defaults

Author: ishaan-arora-1

NAMESPACE

@@ -217,12 +217,11 @@ importFrom(dplyr,inner_join)
 importFrom(dplyr,left_join)
 importFrom(dplyr,mutate)
 importFrom(dplyr,n)
-importFrom(dplyr,one_of)
 importFrom(dplyr,pull)
 importFrom(dplyr,rename)
 importFrom(dplyr,select)
+importFrom(dplyr,slice_min)
 importFrom(dplyr,summarise)
-importFrom(dplyr,top_n)
 importFrom(dplyr,ungroup)
 importFrom(dplyr,vars)
 importFrom(ggplot2,"%+replace%")

NEWS.md

@@ -1,7 +1,7 @@
 # bayesplot (development version)
 
-* Deprecate user-facing `size` arguments that controlled line width in favor of linewidth` across all plotting functions.
-* Deprecate the `fatten` argument in `ppc_intervals()`, `ppd_intervals()`,`ppc_loo_intervals()`, `ppc_bars()`, and their grouped variants. Point size in`geom_pointrange()` is now controlled directly by `size`.
+* Deprecate user-facing `size` arguments that controlled line width in favor of `linewidth` across all plotting functions.
+* Deprecate the `fatten` argument in `ppc_intervals()`, `ppd_intervals()`, `ppc_loo_intervals()`, `ppc_bars()`, and their grouped variants. Point size in `geom_pointrange()` is now controlled directly by `size`.
 * Added unit tests for previously untested edge cases in `param_range()`, `param_glue()`, and `tidyselect_parameters()` (no-match, partial-match, and negation behavior).
 * Bumped minimum version for `rstantools` from `>= 1.5.0` to `>= 2.0.0` .
 * Use `rlang::warn()` and `rlang::inform()` for selected PPC user messages instead of base `warning()` and `message()`.

R/bayesplot-package.R

@@ -6,7 +6,6 @@
 #' @import ggplot2 stats rlang
 #' @importFrom lifecycle deprecated deprecate_warn is_present
 #' @importFrom dplyr %>% summarise group_by select
-#' @importFrom lifecycle deprecated deprecate_warn is_present
 #'
 #' @description
 #' \if{html}{

R/helpers-shared.R

@@ -54,11 +54,18 @@ check_ignored_arguments <- function(..., ok_args = character()) {
 #' @return The resolved linewidth value.
 #' @noRd
 resolve_linewidth <- function(size, linewidth, default_linewidth, calling_fn = NULL) {
+  fn_name <- calling_fn %||% "fn"
+  if (!is.null(size) && !is.null(linewidth)) {
+    abort(paste0(
+      "Both `size` and `linewidth` were supplied to `", fn_name, "()`. ",
+      "Please use only `linewidth`."
+    ))
+  }
   if (!is.null(size)) {
     lifecycle::deprecate_warn(
       when = "1.16.0",
-      what = paste0(calling_fn %||% "fn", "(size)"),
-      with = paste0(calling_fn %||% "fn", "(linewidth)")
+      what = paste0(fn_name, "(size)"),
+      with = paste0(fn_name, "(linewidth)")
     )
     return(size)
   }

R/ppc-discrete.R

@@ -163,7 +163,7 @@ ppc_bars <-
            ...,
            prob = 0.9,
            width = 0.9,
-           size = 2.5,
+           size = 1,
            fatten = deprecated(),
            linewidth = 1,
            freq = TRUE) {
@@ -173,7 +173,7 @@ ppc_bars <-
       check_ignored_arguments(...)
       dots$group <- NULL
     }
-    size <- resolve_fatten(fatten, size, default_size = 2.5,
+    size <- resolve_fatten(fatten, size, default_size = 1,
                            calling_fn = "ppc_bars")
 
     data <- ppc_bars_data(
@@ -231,7 +231,7 @@ ppc_bars_grouped <-
            facet_args = list(),
            prob = 0.9,
            width = 0.9,
-           size = 2.5,
+           size = 1,
            fatten = deprecated(),
            linewidth = 1,
            freq = TRUE) {
@@ -278,12 +278,32 @@ ppc_rootogram <- function(y,
                           style = c("standing", "hanging", "suspended", "discrete"),
                           ...,
                           prob = 0.9,
-                          size = 1,
-                          linewidth = 1,
+                          size = NULL,
+                          linewidth = NULL,
                           bound_distinct = TRUE) {
   check_ignored_arguments(...)
   style <- match.arg(style)
 
+  if (!is.null(size) && !is.null(linewidth)) {
+    abort(paste0(
+      "Both `size` and `linewidth` were supplied to `ppc_rootogram()`. ",
+      "Use `size` for point size and `linewidth` for line width."
+    ))
+  }
+  if (!is.null(size) && is.null(linewidth)) {
+    lifecycle::deprecate_warn(
+      "1.16.0",
+      "ppc_rootogram(size)",
+      details = paste0(
+        "Previously `size` controlled both point size and line width. ",
+        "Now use `size` for point size and `linewidth` for line width."
+      )
+    )
+    linewidth <- size
+  }
+  size <- size %||% 1
+  linewidth <- linewidth %||% 1
+
   data <- .ppc_rootogram_data(
     y = y,
     yrep = yrep,

R/ppc-intervals.R

@@ -136,7 +136,7 @@ ppc_intervals <-
            prob = 0.5,
            prob_outer = 0.9,
            alpha = 0.33,
-           size = 2.5,
+           size = 1,
            fatten = deprecated(),
            linewidth = 1) {
 
@@ -145,7 +145,7 @@ ppc_intervals <-
       check_ignored_arguments(...)
       dots$group <- NULL
     }
-    size <- resolve_fatten(fatten, size, default_size = 2.5,
+    size <- resolve_fatten(fatten, size, default_size = 1,
                            calling_fn = "ppc_intervals")
 
     data <-
@@ -204,7 +204,7 @@ ppc_intervals_grouped <-
            prob = 0.5,
            prob_outer = 0.9,
            alpha = 0.33,
-           size = 2.5,
+           size = 1,
            fatten = deprecated(),
            linewidth = 1) {
     check_ignored_arguments(...)

R/ppc-loo.R

@@ -546,12 +546,12 @@ ppc_loo_intervals <-
            prob = 0.5,
            prob_outer = 0.9,
            alpha = 0.33,
-           size = 2.5,
+           size = 1,
            fatten = deprecated(),
            linewidth = 1,
            order = c("index", "median")) {
     check_ignored_arguments(..., ok_args = list("moment_match"))
-    size <- resolve_fatten(fatten, size, default_size = 2.5,
+    size <- resolve_fatten(fatten, size, default_size = 1,
                            calling_fn = "ppc_loo_intervals")
     y <- validate_y(y)
     order_by_median <- match.arg(order) == "median"

R/ppd-intervals.R

@@ -57,7 +57,7 @@ ppd_intervals <-
            prob = 0.5,
            prob_outer = 0.9,
            alpha = 0.33,
-           size = 2.5,
+           size = 1,
            fatten = deprecated(),
            linewidth = 1) {
 
@@ -66,7 +66,7 @@ ppd_intervals <-
       check_ignored_arguments(...)
       dots$group <- NULL
     }
-    size <- resolve_fatten(fatten, size, default_size = 2.5,
+    size <- resolve_fatten(fatten, size, default_size = 1,
                            calling_fn = "ppd_intervals")
 
     data <- ppd_intervals_data(
@@ -111,7 +111,7 @@ ppd_intervals_grouped <-
            prob = 0.5,
            prob_outer = 0.9,
            alpha = 0.33,
-           size = 2.5,
+           size = 1,
            fatten = deprecated(),
            linewidth = 1) {
     check_ignored_arguments(...)