Skip to content

Commit 5979ec7

Browse files
committed
reviewed copilot suggestions
1 parent 06f189e commit 5979ec7

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

NEWS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# bayesplot (development version)
22

3-
* Added unit test for `.psis_subset()` .
3+
* Added unit test for `.psis_subset()`.
44
* Fixed `is_chain_list()` to correctly reject empty lists instead of silently returning `TRUE`.
55
* Added unit tests for `mcmc_areas_ridges_data()`, `mcmc_parcoord_data()`, and `mcmc_trace_data()`.
66
* Added unit tests for `ppc_error_data()` and `ppc_loo_pit_data()` covering output structure, argument handling, and edge cases.

tests/testthat/test-ppc-loo.R

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,14 +217,13 @@ test_that(".psis_subset output structure matches valid psis object", {
217217
skip_if_not_installed("loo")
218218

219219
subset_idx <- 1:10
220+
orig_dims <- dim(psis1)
220221
result <- .psis_subset(psis1, subset_idx)
221222

222223
# class preserved
223-
224224
expect_s3_class(result, "psis")
225225

226226
# log_weights columns match subset length, rows unchanged
227-
orig_dims <- dim(psis1)
228227
expect_equal(ncol(result$log_weights), length(subset_idx))
229228
expect_equal(nrow(result$log_weights), orig_dims[1])
230229

0 commit comments

Comments
 (0)