Merge pull request #466 from ishaan-arora-1/fix/remove-dead-code-464

Remove dead ggplot2 version check and redundant stringsAsFactors (#464)

Author: jgabry

R/bayesplot-colors.R

@@ -189,7 +189,7 @@ color_scheme_view <- function(scheme = NULL) {
 
 #' @export
 print.bayesplot_scheme <- function(x, ...) {
-  tab <- data.frame(unlist(x, use.names = FALSE), stringsAsFactors = FALSE)
+  tab <- data.frame(unlist(x, use.names = FALSE))
   colnames(tab) <- attr(x, "scheme_name") %||% "hex_color"
   print(tab, ...)
 }

R/zzz.R

@@ -5,10 +5,6 @@
   packageStartupMessage("- bayesplot theme set to bayesplot::theme_default()")
   packageStartupMessage("   * Does _not_ affect other ggplot2 plots")
   packageStartupMessage("   * See ?bayesplot_theme_set for details on theme setting")
-  if (utils::packageVersion("ggplot2") < "3.4.0") {
-    packageStartupMessage("\nbayesplot works best with ggplot2 version >= 3.4.0. ",
-                          "\nUse update.packages('ggplot2') to update.")
-  }
 }
 .onLoad <- function(libname, pkgname) {
   bayesplot_theme_set()

tests/testthat/data-for-mcmc-tests.R

@@ -41,8 +41,7 @@ vdiff_dframe_chains_divergences <- data.frame(
   Iteration = rep(1:500, each = 4),
   Parameter = "divergent__",
   Value = rbinom(2000, size = 1, prob = .02),
-  Chain = vdiff_dframe_chains$chain,
-  stringsAsFactors = FALSE
+  Chain = vdiff_dframe_chains$chain
 )
 
 vdiff_dframe_chains_treedepth <- vdiff_dframe_chains_divergences