Skip to content

Commit 6fc54d1

Browse files
committed
fixing discrete rootogram for free scales (facet_args) and adding new test cases
1 parent 154d73e commit 6fc54d1

4 files changed

Lines changed: 356 additions & 5 deletions

File tree

R/ppc-discrete.R

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -406,14 +406,13 @@ ppc_rootogram_grouped <-
406406
g <- eval(ungroup_call("ppc_rootogram", call), parent.frame())
407407

408408
# In style = discrete, scale_y_sqrt() can't handle -Inf values in axis segments
409-
#
410-
use_native_axes <- style == "discrete" && fixed_y(facet_args)
411-
if (!use_native_axes) {
412-
g <- g + force_axes_in_facets()
409+
if (style != "discrete") {
410+
g <- g <- g + force_axes_in_facets()
413411
}
412+
414413
g + bars_group_facets(
415414
facet_args,
416-
force_axes = use_native_axes,
415+
force_axes = style == "discrete",
417416
axis_labels_default = "margins"
418417
)
419418
}
Lines changed: 165 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)