Fix partial argument warnings

Author: hadley

R/ppc-intervals.R

@@ -298,11 +298,11 @@ label_x <- function(x) {
     grouped_d,
     outer_width = prob_outer,
     inner_width = prob,
-    ll = quantile(!! val_col, prob = probs[1]),
-    l  = quantile(!! val_col, prob = probs[2]),
-    m  = quantile(!! val_col, prob = probs[3]),
-    h  = quantile(!! val_col, prob = probs[4]),
-    hh = quantile(!! val_col, prob = probs[5])
+    ll = quantile(!! val_col, probs = probs[1]),
+    l  = quantile(!! val_col, probs = probs[2]),
+    m  = quantile(!! val_col, probs = probs[3]),
+    h  = quantile(!! val_col, probs = probs[4]),
+    hh = quantile(!! val_col, probs = probs[5])
   ))
 }
 

tests/testthat/test-helpers-shared.R

@@ -30,51 +30,51 @@ all_pars <- c("param_1", "param_2",
 
 test_that("select_parameters throws errors if 'explicit' not found", {
   expect_error(select_parameters(explicit = c("alpha", "ALPHA"),
-                                 complete = all_pars),
+                                 complete_pars = all_pars),
                "don't match parameter names: ALPHA")
   expect_error(select_parameters(c("BETA", "ALPHA"), complete = all_pars),
                "don't match parameter names: BETA, ALPHA")
 })
 test_that("select_parameters throws errors if no regex matches", {
   expect_error(select_parameters(explicit = c("alpha", "beta"),
                                  patterns = "tomato|apple",
-                                 complete = all_pars),
+                                 complete_pars = all_pars),
                "No matches for 'regex_pars'")
 })
 
 test_that("select_parameters works with regex", {
   expect_identical(select_parameters(patterns = "param", complete = all_pars),
                    all_pars[-c(7:8)])
 
-  expect_identical(select_parameters(patterns = c("param", "tomato"), complete = all_pars),
+  expect_identical(select_parameters(patterns = c("param", "tomato"), complete_pars = all_pars),
                    all_pars[-c(7:8)])
 
-  expect_identical(select_parameters(patterns = c("param\\[", "tomato"), complete = all_pars),
+  expect_identical(select_parameters(patterns = c("param\\[", "tomato"), complete_pars = all_pars),
                    all_pars[3:6])
 
-  expect_identical(select_parameters(patterns = c("param\\_"), complete = all_pars),
+  expect_identical(select_parameters(patterns = c("param\\_"), complete_pars = all_pars),
                    all_pars[1:2])
 })
 
 test_that("select_parameters works without regex", {
-  expect_identical(select_parameters(explicit = "alpha", complete = all_pars),
+  expect_identical(select_parameters(explicit = "alpha", complete_pars = all_pars),
                    "alpha")
-  expect_identical(select_parameters(c("alpha", "param[1,3,5]"), complete = all_pars),
+  expect_identical(select_parameters(c("alpha", "param[1,3,5]"), complete_pars = all_pars),
                    c("alpha", "param[1,3,5]"))
 })
 
 test_that("select_parameters works with both explicit and regex", {
   expect_identical(select_parameters(explicit = "alpha",
                                      patterns = "param",
-                                     complete = all_pars),
+                                     complete_pars = all_pars),
                    c("alpha", all_pars[-c(7:8)]))
   expect_identical(select_parameters(explicit = "alpha",
                                      patterns = "alpha",
-                                     complete = all_pars),
+                                     complete_pars = all_pars),
                    "alpha")
   expect_identical(select_parameters(explicit = c("alpha", "beta"),
                                      patterns = "param\\[|param\\_",
-                                     complete = all_pars),
+                                     complete_pars = all_pars),
                    c(all_pars[7:8], all_pars[-c(7:8)]))
 })
 

tests/testthat/test-mcmc-diagnostics.R

@@ -105,7 +105,7 @@ test_that("mcmc_acf & mcmc_acf_bar throw correct errors", {
 test_that("mcmc_rhat renders correctly", {
   testthat::skip_on_cran()
 
-  rhats <- seq(from = 1, to = 1.20, length = 10)
+  rhats <- seq(from = 1, to = 1.20, length.out = 10)
 
   p_base <- mcmc_rhat(rhats)
   vdiffr::expect_doppelganger("mcmc_rhat (default)", p_base)
@@ -117,7 +117,7 @@ test_that("mcmc_rhat renders correctly", {
 test_that("mcmc_rhat_hist renders correctly", {
   testthat::skip_on_cran()
 
-  rhats <- seq(from = 1, to = 1.20, length = 10)
+  rhats <- seq(from = 1, to = 1.20, length.out = 10)
 
   p_base <- mcmc_rhat_hist(rhats)
   vdiffr::expect_doppelganger("mcmc_rhat_hist (default)", p_base)
@@ -130,7 +130,7 @@ test_that("mcmc_rhat_hist renders correctly", {
 test_that("mcmc_neff renders correctly", {
   testthat::skip_on_cran()
 
-  neffs <- seq(from = 0, to = 1, length = 20)
+  neffs <- seq(from = 0, to = 1, length.out = 20)
 
   p_base <- mcmc_neff(neffs)
   vdiffr::expect_doppelganger("mcmc_neff (default)", p_base)
@@ -139,7 +139,7 @@ test_that("mcmc_neff renders correctly", {
 test_that("mcmc_neff_hist renders correctly", {
   testthat::skip_on_cran()
 
-  neffs <- seq(from = 0, to = 1, length = 20)
+  neffs <- seq(from = 0, to = 1, length.out = 20)
 
   p_base <- mcmc_neff_hist(neffs)
   vdiffr::expect_doppelganger("mcmc_neff_hist (default)", p_base)

tests/testthat/test-mcmc-intervals.R

@@ -187,7 +187,7 @@ test_that("mcmc_intervals renders correctly", {
   p_inner <- mcmc_intervals(vdiff_dframe, prob = .1)
   vdiffr::expect_doppelganger("mcmc_intervals (inner)", p_inner)
 
-  rhats <- seq(from = 1, to = 1.15, length = 5)
+  rhats <- seq(from = 1, to = 1.15, length.out = 5)
   p_rhats <- mcmc_intervals(vdiff_dframe, rhat = rhats)
   vdiffr::expect_doppelganger("mcmc_intervals (rhats)", p_rhats)
 
@@ -216,7 +216,7 @@ test_that("mcmc_areas renders correctly", {
   p_inner <- mcmc_areas(vdiff_dframe, prob = .1)
   vdiffr::expect_doppelganger("mcmc_areas (inner)", p_inner)
 
-  rhats <- seq(from = 1, to = 1.15, length = 5)
+  rhats <- seq(from = 1, to = 1.15, length.out = 5)
   p_rhats <- mcmc_areas(vdiff_dframe, rhat = rhats)
   vdiffr::expect_doppelganger("mcmc_areas (rhats)", p_rhats)