final clean up

Author: tjmahr

R/bayesplot-helpers.R

@@ -489,17 +489,17 @@ as_tagged_function <- function(f = NULL, fallback = "func") {
   f_expr <- quo_get_expr(qf)
   f_fn <- f
 
-  if (rlang::is_character(f)) {      # f = "mean"
+  if (is_character(f)) {        # f = "mean"
     # using sym() on the evaluated `f` means that a variable that names a
     # function string `x <- "mean"; as_tagged_function(x)` will be lost
     # but that seems okay
-    f_expr <- rlang::sym(f)
+    f_expr <- sym(f)
     f_fn <- match.fun(f)
-  } else if (is_null(f)) {           # f = NULL
+  } else if (is_null(f)) {      # f = NULL
     f_fn <- identity
-    f_expr <- rlang::sym(fallback)
-  } else if (is_callable(f)) {       # f = mean or f = function(x) mean(x)
-    f_expr <- f_expr                 # or f = ~mean(.x)
+    f_expr <- sym(fallback)
+  } else if (is_callable(f)) {  # f = mean or f = function(x) mean(x)
+    f_expr <- f_expr            # or f = ~mean(.x)
     f_fn <- as_function(f)
   }
 
@@ -512,8 +512,8 @@ as_tagged_function <- function(f = NULL, fallback = "func") {
   }
 
   attr(f_fn, "tagged_expr") <- f_expr
-  attr(f_fn, "is_anonymous_function") <- is_call(f_expr, name = "function") ||
-    is_formula(f_expr)
+  attr(f_fn, "is_anonymous_function") <-
+    is_call(f_expr, name = "function") || is_formula(f_expr)
   f_fn
 }
 

R/ppc-errors.R

@@ -443,9 +443,12 @@ error_avg_label <- function(stat = NULL) {
     e <- sym("stat")
   }
   de <- deparse1(e)
-  # dummy globals to pass R check for globals
+
+  # create some dummy variables to pass the R package check for
+  # global variables in the expression below
   italic <- sym("italic")
   y <- sym("y")
+
   expr(paste((!!de))*(italic(y) - italic(y)[rep]))
 }
 

R/ppc-scatterplots.R

@@ -38,8 +38,8 @@
 #'    A single scatterplot of `y` against the average values of `yrep`, i.e.,
 #'    the points `(x,y) = (average(yrep[, n]), y[n])`, where each `yrep[, n]` is
 #'    a vector of length equal to the number of posterior draws and `average()`
-#'    is summary statistic. Unlike for `ppc_scatter()`, for `ppc_scatter_avg()`
-#'    `yrep` should contain many draws (rows).
+#'    is a summary statistic. Unlike for `ppc_scatter()`, for
+#'    `ppc_scatter_avg()` `yrep` should contain many draws (rows).
 #'   }
 #'   \item{`ppc_scatter_avg_grouped()`}{
 #'    The same as `ppc_scatter_avg()`, but a separate plot is generated for
@@ -229,9 +229,12 @@ yrep_avg_label <- function(stat = NULL) {
     e <- sym("stat")
   }
   de <- deparse1(e)
-  # dummy globals to pass R check for globals
+
+  # create some dummy variables to pass the R package check for
+  # global variables in the expression below
   italic <- sym("italic")
   y <- sym("y")
+
   expr(paste((!!de))*(italic(y)[rep]))
 }