Merge branch 'master' into fix/use-expansion-helper-in-scale-expand

Author: jgabry

NEWS.md

@@ -12,6 +12,7 @@
 * Default to `quantiles=100` for all dot plots by @behramulukir (#402)
 * Use `"neff_ratio"` consistently in diagnostic color scale helpers to avoid relying on partial matching of `"neff"`.
 * Replace `expand = c(mult, add)` with `ggplot2::expansion()` helper in scale functions for consistency with ggplot2 >= 3.3.0 style.
+* Replace uses of `geom_bar(stat = "identity")` with the more idiomatic ggplot2 form `geom_col()` 
 
 # bayesplot 1.15.0
 

R/bayesplot-colors.R

@@ -222,9 +222,8 @@ plot_scheme <- function(scheme = NULL) {
   )
 
   ggplot(color_data, aes(x = .data$name, y = .data$value, fill = .data$group)) +
-    geom_bar(
+    geom_col(
       width = .5,
-      stat = "identity",
       color = "white",
       linewidth = 0.1
     ) +

R/mcmc-diagnostics.R

@@ -541,9 +541,7 @@ drop_NAs_and_warn <- function(x) {
       bayesplot_theme_get()
     if (style == "bar") {
       graph <- graph +
-        geom_bar(
-          position = "identity",
-          stat = "identity",
+        geom_col(
           linewidth = 0.2,
           fill = get_color("l"),
           color = get_color("lh"),