Skip to content

Commit e8234b4

Browse files
authored
Merge pull request #458 from ishaan-arora-1/fix/replace-deprecated-UQ-457
Replace deprecated UQ() with !! operator (#457)
2 parents 3f4e352 + 264adcd commit e8234b4

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

R/mcmc-parcoord.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,8 @@ mcmc_parcoord <-
132132

133133

134134
divg <- sym("Divergent")
135-
draws <- dplyr::filter(data, UQ(divg) == 0)
136-
div_draws <- dplyr::filter(data, UQ(divg) == 1)
135+
draws <- dplyr::filter(data, !!divg == 0)
136+
div_draws <- dplyr::filter(data, !!divg == 1)
137137
has_divs <- isTRUE(nrow(div_draws) > 0)
138138

139139
graph <- ggplot(draws, aes(
@@ -191,7 +191,7 @@ mcmc_parcoord_data <-
191191
# 'Parameter' and 'Value' so need to be a little careful)
192192
divs <- np %>%
193193
validate_nuts_data_frame() %>%
194-
dplyr::filter(UQ(param) == "divergent__") %>%
194+
dplyr::filter(!!param == "divergent__") %>%
195195
select(- !!param) %>%
196196
rename("Divergent" = !!value)
197197

R/mcmc-scatterplots.R

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -352,10 +352,10 @@ mcmc_pairs <- function(x,
352352
param <- sym("Parameter")
353353
val <- sym("Value")
354354
np <- validate_nuts_data_frame(np, lp)
355-
divs <- dplyr::filter(np, UQ(param) == "divergent__") %>% pull(UQ(val))
355+
divs <- dplyr::filter(np, !!param == "divergent__") %>% pull(!!val)
356356
divergent__ <- matrix(divs, nrow = n_iter * n_chain, ncol = n_param)[, 1]
357357
if (!no_max_td) {
358-
gt_max_td <- (dplyr::filter(np, UQ(param) == "treedepth__") %>% pull(UQ(val))) >= max_treedepth
358+
gt_max_td <- (dplyr::filter(np, !!param == "treedepth__") %>% pull(!!val)) >= max_treedepth
359359
max_td_hit__ <- matrix(gt_max_td, nrow = n_iter * n_chain, ncol = n_param)[, 1]
360360
}
361361
}
@@ -674,11 +674,11 @@ pairs_condition <- function(chains = NULL, draws = NULL, nuts = NULL) {
674674
divg <- sym("Divergent")
675675
xydata$Divergent <-
676676
np %>%
677-
dplyr::filter(UQ(param) == "divergent__") %>%
678-
pull(UQ(val))
677+
dplyr::filter(!!param == "divergent__") %>%
678+
pull(!!val)
679679

680-
divdata <- dplyr::filter(xydata, UQ(divg) == 1)
681-
xydata <- dplyr::filter(xydata, UQ(divg) == 0)
680+
divdata <- dplyr::filter(xydata, !!divg == 1)
681+
xydata <- dplyr::filter(xydata, !!divg == 0)
682682
}
683683

684684
graph <- ggplot(data = xydata, aes(x = .data$x, y = .data$y)) +
@@ -880,7 +880,7 @@ handle_condition <- function(x, condition=NULL, np=NULL, lp=NULL) {
880880

881881
} else {
882882
param <- sym("Parameter")
883-
mark <- dplyr::filter(np, UQ(param) == condition)
883+
mark <- dplyr::filter(np, !!param == condition)
884884
mark <- unstack_to_matrix(mark, Value ~ Chain)
885885
}
886886
if (condition == "divergent__") {

R/mcmc-traces.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,7 @@ divergence_rug <- function(np, np_style, n_iter, n_chain) {
789789
divg <- sym("Divergent")
790790

791791
div_info <- np %>%
792-
dplyr::filter(UQ(param) == "divergent__") %>%
792+
dplyr::filter(!!param == "divergent__") %>%
793793
group_by(!! iter) %>%
794794
summarise(
795795
Divergent = ifelse(sum(!! val) > 0, !! iter, NA)

0 commit comments

Comments
 (0)