Preserve S3 dispatch on deprecated rhat()/neff_ratio()

Author: utkarshpawade

NAMESPACE

@@ -17,6 +17,7 @@ S3method(log_posterior,stanfit)
 S3method(log_posterior,stanreg)
 S3method(melt_mcmc,matrix)
 S3method(melt_mcmc,mcmc_array)
+S3method(neff_ratio,default)
 S3method(num_chains,data.frame)
 S3method(num_chains,mcmc_array)
 S3method(num_iters,data.frame)
@@ -36,6 +37,7 @@ S3method(pp_check,default)
 S3method(print,bayesplot_function_list)
 S3method(print,bayesplot_grid)
 S3method(print,bayesplot_scheme)
+S3method(rhat,default)
 export(abline_01)
 export(available_mcmc)
 export(available_ppc)

R/bayesplot-extractors.R

@@ -81,6 +81,9 @@ extract_neff_ratio <- function(object, ...) {
 }
 
 # rhat -------------------------------------------------------------
+# Kept as an S3 generic (not just a wrapper) so third-party methods
+# registered against rhat (e.g. brms::rhat.brmsfit) still dispatch
+# during the deprecation window.
 #' @rdname bayesplot-extractors
 #' @export
 rhat <- function(object, ...) {
@@ -94,8 +97,16 @@ rhat <- function(object, ...) {
       "masking posterior::rhat(), which computes R-hat)."
     )
   )
+  UseMethod("rhat")
+}
+
+#' @rdname bayesplot-extractors
+#' @export
+#' @method rhat default
+rhat.default <- function(object, ...) {
   extract_rhat(object, ...)
 }
+
 # neff_ratio -------------------------------------------------------------
 #' @rdname bayesplot-extractors
 #' @export
@@ -110,6 +121,13 @@ neff_ratio <- function(object, ...) {
       "size ratios (and to avoid masking posterior's ESS functions)."
     )
   )
+  UseMethod("neff_ratio")
+}
+
+#' @rdname bayesplot-extractors
+#' @export
+#' @method neff_ratio default
+neff_ratio.default <- function(object, ...) {
   extract_neff_ratio(object, ...)
 }