skip PIT visual tests until new rstantools is released#370
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 35 35
Lines 5748 5748
=======================================
Hits 5669 5669
Misses 79 79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will be finally releasing the next version of rstantools soon, but the updated PIT algorithm breaks a few visual tests in bayesplot. This PR disables those tests. I will reenable them and update them to the new rstantools after releasing rstantools.
I will probably do a release of bayesplot in the next few days (including this PR and also everything @behramulukir has added so far) in order to make sure these tests are disabled on CRAN so that the rstantools submission doesn't break the version of bayesplot on CRAN.