Replace select(-c(col)) with select(-all_of(col))#487
Replace select(-c(col)) with select(-all_of(col))#487utkarshpawade wants to merge 1 commit intostan-dev:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 35 35
Lines 5860 5860
=======================================
Hits 5782 5782
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think these changes are good, but are you sure there are warnings? I don't get any deprecation warnings. Can you share the warning messages you were seeing? |
jgabry
left a comment
There was a problem hiding this comment.
I think these changes are good (and we can merge this soon), but are you sure there are warnings? I don't get any deprecation warnings. Can you share the warning messages you were seeing?
|
My bad, you're right. The warning is for external character variables, not inline strings like these. No actual warnings here, it's just a style thing. Happy to merge or close, up to you. |
Fixes #486
PR Description:
select(-c("center"), "m")andselect(-c("density"))withselect(-all_of("center"), all_of("m"))andselect(-all_of("density"))inmcmc-intervals.R(lines 759, 845)c()for deselection inselect()