Skip to content

Replace select(-c(col)) with select(-all_of(col))#487

Closed
utkarshpawade wants to merge 1 commit intostan-dev:masterfrom
utkarshpawade:fix/use-all-of-in-select-deselection
Closed

Replace select(-c(col)) with select(-all_of(col))#487
utkarshpawade wants to merge 1 commit intostan-dev:masterfrom
utkarshpawade:fix/use-all-of-in-select-deselection

Conversation

@utkarshpawade
Copy link
Copy Markdown
Contributor

Fixes #486
PR Description:

  • Replaced select(-c("center"), "m") and select(-c("density")) with select(-all_of("center"), all_of("m")) and select(-all_of("density")) in mcmc-intervals.R (lines 759, 845)
  • Fixes deprecation warnings from dplyr 1.0.0+ when using character vectors inside c() for deselection in select()

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.66%. Comparing base (906cd5c) to head (5e82ff9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          35       35           
  Lines        5860     5860           
=======================================
  Hits         5782     5782           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry
Copy link
Copy Markdown
Member

jgabry commented Mar 16, 2026

  • Fixes deprecation warnings from dplyr 1.0.0+ when using character vectors inside c() for deselection in select()

I think these changes are good, but are you sure there are warnings? I don't get any deprecation warnings. Can you share the warning messages you were seeing?

Copy link
Copy Markdown
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are good (and we can merge this soon), but are you sure there are warnings? I don't get any deprecation warnings. Can you share the warning messages you were seeing?

@utkarshpawade
Copy link
Copy Markdown
Contributor Author

My bad, you're right. The warning is for external character variables, not inline strings like these. No actual warnings here, it's just a style thing. Happy to merge or close, up to you.

@jgabry jgabry closed this Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace select(-c("col")) with select(-all_of("col")) in mcmc-intervals.R

3 participants