Remove redundant stat = "identity" from geom_ridgeline() and replace geom_density_ridges(stat = "identity") with geom_ridgeline() in mcmc-distributions.R#491
Closed
utkarshpawade wants to merge 2 commits intostan-dev:masterfrom
Conversation
utkarshpawade
changed the title
utkarshpawade
force-pushed
the
fix/replace-geom-density-ridges-stat-identity
branch
from
f564a00 to
d6d5a62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #490
Summary
ggridges::geom_density_ridges(stat = "identity")withggridges::geom_ridgeline()inmcmc-intervals.R(line 520) andmcmc-distributions.R(line 326), since density is pre-computed and mapped toheight. See ggridges docsstat = "identity"fromggridges::geom_ridgeline()call inmcmc-intervals.R(line 561) where it is already the default