Fix edge-case validation in nuts_params.list()#531
Open
utkarshpawade wants to merge 2 commits intostan-dev:masterfrom
Open
Fix edge-case validation in nuts_params.list()#531utkarshpawade wants to merge 2 commits intostan-dev:masterfrom
utkarshpawade wants to merge 2 commits intostan-dev:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #530 by adding explicit input validation to nuts_params.list() so edge-case inputs (empty lists and zero-row matrices) fail with clear, user-facing errors rather than downstream/internal failures.
Changes:
- Add early validation in
nuts_params.list()for empty list inputs and zero-row matrices. - Add unit tests covering empty list, zero-row matrix, and single-chain list behavior.
- Document the behavioral change in
NEWS.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
R/bayesplot-extractors.R |
Adds early input validation and clearer error messages in nuts_params.list(). |
tests/testthat/test-extractors.R |
Adds regression tests for new edge-case validations and a single-chain success case. |
NEWS.md |
Notes the new validation behavior in the development changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #531 +/- ##
==========================================
- Coverage 98.71% 98.67% -0.04%
==========================================
Files 35 35
Lines 5903 5907 +4
==========================================
+ Hits 5827 5829 +2
- Misses 76 78 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #530
nuts_params.list()for empty lists and zero-row matrices with clear error messages