Skip to content

Commit 9e96a7e

Browse files
authored
Merge pull request #698 from stan-dev/fix/696-diagnose-wording
Update wording on `diagnose()` suggestion
2 parents 0506f16 + 307b972 commit 9e96a7e

File tree

3 files changed

+184
-155
lines changed

3 files changed

+184
-155
lines changed

.github/workflows/main.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
5050
steps:
5151
- name: Check out github
52-
uses: actions/checkout@v4
52+
uses: actions/checkout@v3
5353

5454
- name: Set up Python ${{ matrix.python-version }}
5555
uses: actions/setup-python@v4
@@ -87,12 +87,17 @@ jobs:
8787
run: python -m pip freeze
8888

8989
- name: CmdStan installation cacheing
90+
id: cache-cmdstan
9091
if: ${{ !startswith(needs.get-cmdstan-version.outputs.version, 'git:') }}
9192
uses: actions/cache@v3
9293
with:
9394
path: ~/.cmdstan
9495
key: ${{ runner.os }}-cmdstan-${{ needs.get-cmdstan-version.outputs.version }}-${{ hashFiles('**/install_cmdstan.py') }}
9596

97+
- name: Delete precompiled header (MacOS)
98+
if: matrix.os == 'macos-latest' && steps.cache-cmdstan.outputs.cache-hit == 'true'
99+
run: rm -f ~/.cmdstan/cmdstan-${{ needs.get-cmdstan-version.outputs.version }}/stan/src/stan/model/*.hpp.gch
100+
96101
- name: Install CmdStan (Linux, macOS)
97102
if: matrix.os != 'windows-latest'
98103
run: |

cmdstanpy/stanfit/mcmc.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,8 @@ def _check_sampler_diagnostics(self) -> None:
366366
f'({((self._max_treedepths[i]/ct_iters)*100):.1f}%)'
367367
)
368368
diagnostics.append(
369-
'Use function "diagnose()" to see further information.'
369+
'Use the "diagnose()" method on the CmdStanMCMC object'
370+
' to see further information.'
370371
)
371372
get_logger().warning('\n\t'.join(diagnostics))
372373

0 commit comments

Comments
 (0)