Skip to content

Fix typing issues in tests #826

Merged
WardBrian merged 4 commits into
developfrom
mypy-tests
Nov 4, 2025
Merged

Fix typing issues in tests #826
WardBrian merged 4 commits into
developfrom
mypy-tests

Conversation

@WardBrian
Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Enables mypy for the test files. Based on #825

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian
Copy link
Copy Markdown
Member Author

@amas0 mind taking a peek?

Copy link
Copy Markdown
Collaborator

@amas0 amas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One minor suggestion and one thought

Comment thread test/__init__.py Outdated
Comment thread test/test_install_cmdstan.py
@WardBrian WardBrian merged commit fd691c8 into develop Nov 4, 2025
19 checks passed
@WardBrian WardBrian deleted the mypy-tests branch November 4, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants