Remove legacy windows pareto test skips

Author: jgabry

.github/workflows/R-CMD-check.yaml

@@ -47,7 +47,6 @@ jobs:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
       NOT_CRAN: true
       CMDSTANR_OPENCL_TESTS: ${{ matrix.config.opencl }}
-      CMDSTANR_SKIP_PARETO_SMOOTH_INIT_TESTS: ${{ matrix.config.os == 'windows-2022' && matrix.config.r == '4.1' }}
       CMDSTAN_TEST_TARBALL_URL: ${{ github.event.inputs.tarball_url }}
       PKG_SYSREQS_DB_UPDATE_TIMEOUT: 30s
 

tests/testthat/helper-envvars-and-paths.R

@@ -23,9 +23,3 @@ delete_extensions <- function() {
     c("", ".o",".hpp")
   }
 }
-
-skip_if_legacy_win41_pareto <- function() {
-  if (tolower(Sys.getenv("CMDSTANR_SKIP_PARETO_SMOOTH_INIT_TESTS")) %in% c("1", "true")) {
-    skip("Skipping tests requiring posterior::pareto_smooth on windows-2022 R 4.1 CI.")
-  }
-}

tests/testthat/test-fit-init.R

@@ -49,23 +49,20 @@ test_that("Subsets of parameters are allowed", {
 })
 
 test_that("Pathfinder works as init", {
-  skip_if_legacy_win41_pareto()
   mod_logistic <- testing_model("logistic")
   utils::capture.output(fit_path_init <- mod_logistic$pathfinder(
     seed=1234, data = data_list_logistic, refresh = 0, num_paths = 1))
   expect_no_error(test_inits(mod_logistic, fit_path_init, data_list_logistic))
 })
 
 test_that("Multi Pathfinder method works as init", {
-  skip_if_legacy_win41_pareto()
   mod_logistic <- testing_model("logistic")
   utils::capture.output(fit_path_init <- mod_logistic$pathfinder(seed=1234,
     data = data_list_logistic, refresh = 0, num_paths = 4))
   expect_no_error(test_inits(mod_logistic, fit_path_init, data_list_logistic))
 })
 
 test_that("Pathfinder method with psis_resample as false works as init", {
-  skip_if_legacy_win41_pareto()
   mod_logistic <- testing_model("logistic")
   utils::capture.output(fit_path_init <- mod_logistic$pathfinder(
     seed=1234, data = data_list_logistic, refresh = 0, num_paths = 1,
@@ -75,7 +72,6 @@ test_that("Pathfinder method with psis_resample as false works as init", {
 
 
 test_that("Multi Pathfinder method with psis_resample as false works as init", {
-  skip_if_legacy_win41_pareto()
   mod_logistic <- testing_model("logistic")
   utils::capture.output(fit_path_init <- mod_logistic$pathfinder(
     seed=1234, data = data_list_logistic, refresh = 0, num_paths = 4,
@@ -101,7 +97,6 @@ test_that("Multi Pathfinder method with calculate_lp as false works as init", {
 })
 
 test_that("Variational method works as init", {
-  skip_if_legacy_win41_pareto()
   mod_logistic <- testing_model("logistic")
   utils::capture.output(fit_vb_init <- mod_logistic$variational(
     data = data_list_logistic, seed=1234, refresh = 0))

tests/testthat/test-model-init.R

@@ -314,7 +314,6 @@ test_that("Initial values for single-element containers treated correctly", {
 })
 
 test_that("Pathfinder inits do not drop dimensions", {
-  skip_if_legacy_win41_pareto()
   modcode <- "
   data {
     int N;