Model specific version#1079
Merged
jgabry merged 2 commits intostan-dev:masterfrom Apr 17, 2025
Merged
Conversation
2 tasks
Member
|
Thanks! This looks good to me. @andrjohns any issues with this on your end? |
Member
|
Ok great will go ahead and merge since everything is passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Precursor to #1022 .
To properly handle options when cmdstanr is provided a pre-compiled binary, we need to base arg checking on the cpp args and cmdstan version that the binary was complied with. This version may or may not be the same as the version currently set. This PR does not solve this problem completely. It is a precursor to the solution by at least storing a cmdstan version value in the model object.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Max Planck Institute of Animal Behavior
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: