Extract exe path logic#1080
Conversation
9bcafb6 to
2bd6db4
Compare
|
hmm...I just rebased and things seem to have gotten worse. |
Looks like now windows-oldrel is passing but there are some ubuntu failures. They seem unrelated to this PR and more like some intermittent failures that we see with GitHub Actions from time to time. |
|
so then is there anything stopping this from being merged? |
|
I just restarted the checks that failed. Looks like the test coverage one is still failing for the same reason (I don’t think that failure should prevent us from merging this). The one for the unit tests on Ubuntu with r-devel now seems to be running and has made it past where it failed last time. So I guess let’s let that one finish and then merge this unless it fails for some reason related to the PR (seems unlikely). |
Merging now. Sorry, forgot to say yesterday that I was going to try re-running the failed checks. |
|
thanks! |
Submission Checklist
Summary
This logic will be reused in the initiate method for #1022 work. For now just breaking it into its own function.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Max Planck Institute of Animal Behavior
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: