Merge pull request #330 from ishaan-arora-1/fix/missing-space-in-order-stat-warning

jgabry · web-flow · commit aab19c923c74 · 2026-02-27T15:41:27.000-07:00
Fix missing space in order statistics warning message
diff --git a/R/loo_compare.R b/R/loo_compare.R
@@ -327,7 +327,7 @@ loo_order_stat_check <- function(loos, ord) {
 
   if (max(elpd_diff) <= order_stat) {
     # flag warning if we suspect no model is theoretically better than the baseline
-    warning("Difference in performance potentially due to chance.",
+    warning("Difference in performance potentially due to chance. ",
             "See McLatchie and Vehtari (2023) for details.",
             call. = FALSE)
   }
diff --git a/tests/testthat/test_compare.R b/tests/testthat/test_compare.R
@@ -62,7 +62,8 @@ test_that("loo_compare throws appropriate warnings", {
   })
   expect_warning(
     loo_compare(w_list),
-    "Difference in performance potentially due to chance"
+    "Difference in performance potentially due to chance. See McLatchie and Vehtari (2023) for details.",
+    fixed = TRUE
   )
 
   w_list_short <- lapply(1:4, function(x) {

Original file line number	Diff line number	Diff line change
`@@ -327,7 +327,7 @@ loo_order_stat_check <- function(loos, ord) {`
`327`	`327`
`328`	`328`	`if (max(elpd_diff) <= order_stat) {`
`329`	`329`	`# flag warning if we suspect no model is theoretically better than the baseline`
`330`		`- warning("Difference in performance potentially due to chance.",`
	`330`	`+ warning("Difference in performance potentially due to chance. ",`
`331`	`331`	`"See McLatchie and Vehtari (2023) for details.",`
`332`	`332`	`call. = FALSE)`
`333`	`333`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,8 @@ test_that("loo_compare throws appropriate warnings", {`
`62`	`62`	`})`
`63`	`63`	`expect_warning(`
`64`	`64`	`loo_compare(w_list),`
`65`		`- "Difference in performance potentially due to chance"`
	`65`	`+ "Difference in performance potentially due to chance. See McLatchie and Vehtari (2023) for details.",`
	`66`	`+ fixed = TRUE`
`66`	`67`	`)`
`67`	`68`
`68`	`69`	`w_list_short <- lapply(1:4, function(x) {`