Fixed error message printing with too much work and extended tests to catch it (design-doc #19)

Author: bbbales2

stan/math/prim/functor/ode_rk45.hpp

@@ -132,7 +132,7 @@ ode_rk45_tol_impl(const char* function_name, const F& f,
         std::end(ts_vec), step_size, filtered_observer,
         max_step_checker(max_num_steps));
   } catch (const no_progress_error& e) {
-    throw_domain_error("integrate_ode_rk45", "", ts_vec[time_index + 1],
+    throw_domain_error(function_name, "", ts_vec[time_index + 1],
                        "Failed to integrate to next output time (",
                        ") in less than max_num_steps steps");
   }

test/unit/math/prim/functor/ode_rk45_tol_prim_test.cpp

@@ -444,5 +444,5 @@ TEST(ode_rk45_tol_prim, too_much_work) {
   EXPECT_THROW_MSG(stan::math::ode_rk45_tol(CosArg1(), y0, t0, ts, 1e-6, 1e-6,
                                             100, nullptr, a),
                    std::domain_error,
-                   "Failed to integrate to next output time");
+                   "ode_rk45_tol:  Failed to integrate to next output time");
 }

test/unit/math/rev/functor/ode_adams_tol_prim_test.cpp

@@ -444,5 +444,5 @@ TEST(ode_adams_tol_prim, too_much_work) {
   EXPECT_THROW_MSG(stan::math::ode_adams_tol(CosArg1(), y0, t0, ts, 1e-6, 1e-6,
                                              100, nullptr, a),
                    std::domain_error,
-                   "Failed to integrate to next output time");
+                   "ode_adams_tol:  Failed to integrate to next output time");
 }

test/unit/math/rev/functor/ode_adams_tol_rev_test.cpp

@@ -586,5 +586,5 @@ TEST(StanMathOde_ode_adams_tol, too_much_work) {
   EXPECT_THROW_MSG(stan::math::ode_adams_tol(CosArg1(), y0, t0, ts, 1e-6, 1e-6,
                                              100, nullptr, a),
                    std::domain_error,
-                   "Failed to integrate to next output time");
+                   "ode_adams_tol:  Failed to integrate to next output time");
 }

test/unit/math/rev/functor/ode_bdf_tol_prim_test.cpp

@@ -442,5 +442,5 @@ TEST(ode_bdf_tol_prim, too_much_work) {
   EXPECT_THROW_MSG(stan::math::ode_bdf_tol(CosArg1(), y0, t0, ts, 1e-6, 1e-6,
                                            100, nullptr, a),
                    std::domain_error,
-                   "Failed to integrate to next output time");
+                   "ode_bdf_tol:  Failed to integrate to next output time");
 }

test/unit/math/rev/functor/ode_bdf_tol_rev_test.cpp

@@ -586,5 +586,5 @@ TEST(StanMathOde_ode_bdf_tol, too_much_work) {
   EXPECT_THROW_MSG(stan::math::ode_bdf_tol(CosArg1(), y0, t0, ts, 1e-6, 1e-6,
                                            100, nullptr, a),
                    std::domain_error,
-                   "Failed to integrate to next output time");
+                   "ode_bdf_tol:  Failed to integrate to next output time");
 }

test/unit/math/rev/functor/ode_rk45_tol_rev_test.cpp

@@ -586,5 +586,5 @@ TEST(StanMathOde_ode_rk45_tol, too_much_work) {
   EXPECT_THROW_MSG(stan::math::ode_rk45_tol(CosArg1(), y0, t0, ts, 1e-6, 1e-6,
                                             100, nullptr, a),
                    std::domain_error,
-                   "Failed to integrate to next output time");
+                   "ode_rk45_tol:  Failed to integrate to next output time");
 }