Update Stan packaging for R-Devel compat#1187
Open
andrjohns wants to merge 3 commits into
Open
Conversation
Member
|
Thanks @andrjohns! @bgoodri what do you think about this approach? |
Contributor
|
Yeah, we are going to have to do something like this when we update StanHeaders for RcppEigen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The workflows for R-devel are currently failing. R is getting a bit stricter with the handling of
.Rbuildignore- items specified there are no longer available during package build. This breaks the current approach of usingcleanupscripts to copy the headers/sources when packaging.This PR works around this by keeping the stan submodule(s) in the
srcfolder and using.Rbuildignoreto keep only the minimum needed sources when packaging.In order to keep within the 100-character path limit when packaging, I've split the
stansubmodule into separatestanandmath. If this approach seems like the way to go, I'll also update the Jenkins process for syncing the two modules.Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: