Cleanup

Author: WardBrian

src/frontend/Promotion.ml

@@ -4,7 +4,7 @@ module UnsizedType = Middle.UnsizedType
 
 (** Type to represent promotions in the typechecker.
   This can be used to return information about how to promote
-  expressions for use in [Ast.Promotion]*)
+  expressions for use in [Ast.Promotion] *)
 type t =
   | NoPromotion
   | IntToReal

src/frontend/Typechecker.ml

@@ -978,9 +978,9 @@ let check_assignment loc cf tenv assign_lhs assign_op assign_rhs =
         |> error in
   verify_assignment_global loc cf block global assign_id ;
   verify_assignment_read_only loc readonly assign_id ;
-  let rhs = check_assignment_operator loc assign_op lhs rhs in
+  let rhs' = check_assignment_operator loc assign_op lhs rhs in
   mk_typed_statement ~return_type:NoReturnType ~loc
-    ~stmt:(Assignment {assign_lhs= lhs; assign_op; assign_rhs= rhs})
+    ~stmt:(Assignment {assign_lhs= lhs; assign_op; assign_rhs= rhs'})
 
 (* target plus-equals / increment log-prob *)
 

test/integration/good/promotion/array_promotion.stan

@@ -16,11 +16,16 @@ data {
    array[N] int xs;
 }
 
+parameters {
+  real r;
+}
+
 transformed parameters {
    array[2,2] real zs = {{2,3},{7,0.5}};
    array[2] complex z1 = {1,3};
    array[2] complex z2 = {1,3.5};
    array[2] complex z3 = {1,3.5i};
+   z3 = {3.5i, r};
 }
 
 model {

test/integration/good/promotion/pretty.expected

@@ -30,11 +30,15 @@ data {
   int N;
   array[N] int xs;
 }
+parameters {
+  real r;
+}
 transformed parameters {
   array[2, 2] real zs = {{2, 3}, {7, 0.5}};
   array[2] complex z1 = {1, 3};
   array[2] complex z2 = {1, 3.5};
   array[2] complex z3 = {1, 3.5i};
+  z3 = {3.5i, r};
 }
 model {
   array[3] int d = {1, 2, 3};