address review comments

Author: nhuurre

src/frontend/Ast_to_Mir.ml

@@ -679,7 +679,7 @@ let migrate_checks_to_end_of_block stmts =
   let checks, not_checks = List.partition_tf ~f:stmt_contains_check stmts in
   not_checks @ checks
 
-let trans_data (p : Ast.typed_program) =
+let gather_data (p : Ast.typed_program) =
   let data = Ast.get_stmts p.datablock in
   List.filter_map data ~f:(function
     | { stmt=

src/frontend/Ast_to_Mir.mli

@@ -1,7 +1,7 @@
 (** Translate from the AST to the MIR *)
 open Middle
 
-val trans_data :
+val gather_data :
      Ast.typed_program
   -> (Expr.Typed.t SizedType.t * Expr.Typed.t Transformation.t * string) list
 

src/middle/Expr.ml

@@ -213,9 +213,8 @@ module Helpers = struct
     match e.Fixed.pattern with
     | FunApp (CompilerInternal (FnMakeRowVec | FnMakeArray), l) -> Some l
     | FunApp
-        ( StanLib (transpose, FnPlain, _)
-        , [{pattern= FunApp (CompilerInternal FnMakeRowVec, l); _}] )
-      when String.equal transpose (Operator.to_string Transpose) ->
+        ( StanLib ("Transpose__", FnPlain, _)
+        , [{pattern= FunApp (CompilerInternal FnMakeRowVec, l); _}] ) ->
         Some l
     | _ -> None
 

src/stanc/stanc.ml

@@ -272,7 +272,7 @@ let use_file filename =
       (Deprecation_analysis.collect_warnings typed_ast) ;
   if !generate_data then
     print_endline
-      (Debug_data_generation.print_data_prog (Ast_to_Mir.trans_data typed_ast)) ;
+      (Debug_data_generation.print_data_prog (Ast_to_Mir.gather_data typed_ast)) ;
   Debugging.typed_ast_logger typed_ast ;
   if not !pretty_print_program then (
     let mir = Ast_to_Mir.trans_prog filename typed_ast in

src/stancjs/stancjs.ml

@@ -92,7 +92,7 @@ let stan2cpp model_name model_string is_flag_set flag_val =
           r.return
             ( Result.Ok
                 (Debug_data_generation.print_data_prog
-                   (Ast_to_Mir.trans_data typed_ast) )
+                   (Ast_to_Mir.gather_data typed_ast) )
             , warnings
             , [] ) ;
         let opt_mir =

test/unit/Debug_data_generation_tests.ml

@@ -3,7 +3,7 @@ open Core_kernel
 open Frontend
 open Debug_data_generation
 
-let print_data_prog ast = print_data_prog (Ast_to_Mir.trans_data ast)
+let print_data_prog ast = print_data_prog (Ast_to_Mir.gather_data ast)
 
 let%expect_test "whole program data generation check" =
   let ast =