Skip to content

Add signatures for student_t_qf #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WardBrian wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add signatures for student_t_qf #1620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
658d668
Add signatures for student_t_qf
WardBrian May 6, 2026
09d0413
Update return types
WardBrian May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/stan_math_signatures/Generate.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ type fkind =
| Cdf
| Ccdf
| UnaryVectorized of return_behavior
| MultiVectorized
[@@deriving show {with_path= false}]

let is_primitive = function
Expand Down Expand Up @@ -156,7 +157,7 @@ let mk_declarative_sig (fnkinds, name, args, mem_pattern) =
| Rng -> ["_rng"]
| Cdf -> ["_cdf"; "_lcdf"]
| Ccdf -> ["_lccdf"]
| UnaryVectorized _ -> [""] in
| UnaryVectorized _ | MultiVectorized -> [""] in
let add_ints = function DVReal -> DIntAndReals | x -> x in
let all_expanded args = all_combinations (List.map ~f:expand_arg args) in
let promoted_dim = function
Expand All @@ -170,6 +171,9 @@ let mk_declarative_sig (fnkinds, name, args, mem_pattern) =
ReturnType (ints_to_real (List.hd_exn args))
| UnaryVectorized ComplexToReals ->
ReturnType (complex_to_real (List.hd_exn args))
| MultiVectorized ->
if List.for_all ~f:UnsizedType.is_scalar_type args then ReturnType UReal
else ReturnType UVector
| _ -> ReturnType UReal in
let create_from_fk_args fk arglists =
List.concat_map arglists ~f:(fun args ->
Expand Down Expand Up @@ -337,6 +341,7 @@ let math_sigs =
; ([basic_vectorized], "std_normal_qf", [DDeepVectorized], SoA)
(* std_normal_qf is an alias for inv_Phi *)
; ([basic_vectorized], "std_normal_log_qf", [DDeepVectorized], SoA)
; ([MultiVectorized], "student_t_qf", [DVReal; DVReal; DVReal; DVReal], SoA)
; ([basic_vectorized], "step", [DReal], AoS)
; ([basic_vectorized], "tan", [DDeepVectorized], SoA)
; ([basic_vectorized], "tanh", [DDeepVectorized], SoA)
Expand Down
Loading