Skip to content

fix(SNOTES-476): fix LinkedItemBubble styling #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amanharwara merged 5 commits into from
Jun 19, 2025
Merged

fix(SNOTES-476): fix LinkedItemBubble styling #2902

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77c9f79
fix(SNOTES-476): fix LinkedItemBubble styling
antsgar Jun 11, 2025
21627f1
fix(SNOTES-476): fix LinkedItemBubble styling
antsgar Jun 12, 2025
ebc7d4c
fix(SNOTES-476): remove inline flex
antsgar Jun 12, 2025
6287e16
fix(SNOTES-476): remove icon height change
antsgar Jun 12, 2025
15f4130
fix(SNOTES-476): fix icons alignment
antsgar Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const LinkedItemBubble = ({
ref={(el) => (ref.current = el as HTMLElement)}
tabIndex={0}
className={classNames(
'group cursor-pointer rounded align-middle [&>*]:align-middle',
'group cursor-pointer rounded ',
'bg-passive-4-opacity-variant outline-1 outline-info hover:bg-contrast focus:bg-contrast focus:outline',
'whitespace-pre-wrap text-left text-sm text-text hover:no-underline focus:no-underline lg:text-xs',
'py-1 pl-1 pr-2',
Expand All @@ -121,7 +121,7 @@ const LinkedItemBubble = ({
title={tagTitle ? tagTitle.longTitle : link.item.title}
onKeyDown={onKeyDown}
>
<Icon type={icon} className={classNames('mr-1 inline', iconClassName)} size="small" />
<Icon type={icon} className={classNames('mr-1 inline h-[1.15em] align-text-top', iconClassName)} size="small" />
{tagTitle && <span className="text-passive-1">{tagTitle.titlePrefix}</span>}
{link.type === 'linked-by' && link.item.content_type !== ContentType.TYPES.Tag && (
<span className={!isBidirectional ? 'hidden group-focus:inline' : ''}>Linked By:</span>
Expand All @@ -131,7 +131,7 @@ const LinkedItemBubble = ({
<button
ref={(el) => (unlinkButtonRef.current = el as HTMLElement)}
role="button"
className="-mr-1 ml-2 inline-flex cursor-pointer border-0 bg-transparent p-0"
className="-mr-1 ml-2 inline-flex cursor-pointer border-0 bg-transparent p-0 h-[1.15em] align-middle"
onClick={onUnlinkClick}
>
<Icon type="close" className="text-neutral hover:text-info" size="small" />
Expand Down
Loading