Merge pull request #95 from standleypg-dev/dockerfile_update

Optimize docker image footprint

Author: standleypg

deployment/Dockerfile

@@ -6,15 +6,10 @@ WORKDIR /deps
 RUN apt update && apt install -y --no-install-recommends \
     nodejs \
     npm \
-    ffmpeg \
     libsodium-dev \
     libopus-dev \
-    yt-dlp \
     wget \
-    unzip \
-    tzdata && \
-    rm -rf /var/lib/apt/lists/* && \
-    ln -sf /usr/share/zoneinfo/Asia/Singapore /etc/localtime
+    unzip
 
 RUN wget -O /tmp/libdave.zip \
     https://github.com/discord/libdave/releases/download/v1.1.1/cpp/libdave-Linux-X64-boringssl.zip && \
@@ -52,14 +47,18 @@ RUN dotnet publish "$PROJECT_PATH" \
     --self-contained false \
     --no-restore
 
-FROM mcr.microsoft.com/dotnet/sdk:10.0 AS final
+FROM mcr.microsoft.com/dotnet/aspnet:10.0 AS final
 
 RUN apt update && apt install -y --no-install-recommends \
     ffmpeg \
     tzdata \
-    yt-dlp && \
-    rm -rf /var/lib/apt/lists/* && \
-    ln -sf /usr/share/zoneinfo/Asia/Singapore /etc/localtime
+    python3 \
+    && rm -rf /var/lib/apt/lists/* \
+    && ln -sf /usr/share/zoneinfo/Asia/Singapore /etc/localtime
+
+# Install latest yt-dlp directly from GitHub releases
+ADD https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp /usr/local/bin/yt-dlp
+RUN chmod a+rx /usr/local/bin/yt-dlp
 
 WORKDIR /app/run
 

src/Infrastructure/Services/YoutubeService.cs

@@ -78,9 +78,18 @@ public async Task<string> GetAudioStreamUrlAsync(string url, CancellationToken c
         try
         {
             var ytdl = new YoutubeDL { YoutubeDLPath = "yt-dlp" };
-            var result = await ytdl.RunVideoDataFetch(url);
-            
-            result.EnsureSuccess();
+            var overrideOptions = new YoutubeDLSharp.Options.OptionSet
+            {
+                Format = "bestaudio/best"
+            };
+            var result = await ytdl.RunVideoDataFetch(url, overrideOptions: overrideOptions);
+
+            if (!result.Success || result.Data?.Formats == null)
+            {
+                _logger.LogWarning("YT-DLP fetch failed for: {Url}. Errors: {Errors}", url,
+                    string.Join("; ", result.ErrorOutput ?? []));
+                return (false, null);
+            }
 
             var httpsFormats = result.Data.Formats
                 .Where(f => f.Protocol != "mhtml")
@@ -97,11 +106,6 @@ public async Task<string> GetAudioStreamUrlAsync(string url, CancellationToken c
                 return (false, null);
             }
 
-            // Verify URL is accessible
-            using var httpClient = new HttpClient();
-            var response = await httpClient.GetAsync(bestAudio.Url);
-            response.EnsureSuccessStatusCode();
-
             return (true, bestAudio.Url);
         }
         catch (Exception ex)

src/Worker/Worker.csproj

@@ -36,8 +36,6 @@
               DestinationFolder="$(OutputPath)"/>
         <Copy SourceFiles="/usr/lib/x86_64-linux-gnu/libopus.so"
               DestinationFolder="$(OutputPath)"/>
-        <Copy SourceFiles="/usr/bin/yt-dlp"
-              DestinationFolder="$(OutputPath)"/>
     </Target>
 
     <PropertyGroup>
@@ -48,7 +46,6 @@
         <NativeLibs Include="/usr/lib/x86_64-linux-gnu/libsodium.so" />
         <NativeLibs Include="/usr/lib/x86_64-linux-gnu/libopus.so" />
         <NativeLibs Include="/usr/lib/libdave.so" />
-        <NativeLibs Include="/usr/bin/yt-dlp" />
     </ItemGroup>
 
     <!-- Copy after build -->