Merge pull request olasunkanmi-SE#374 from olasunkanmi-SE/feature/terminal_viewer

TerminalViewerPanelTerminalViewerHandleruseTerminalStorelistSessionsD…

Author: olasunkanmi-SE

docs/WEBVIEW_UI_AUDIT.md

@@ -259,22 +259,6 @@ These services exist in `src/services/` with **no corresponding handler or UI su
 
 ---
 
-## 7. Dead Code & Cleanup Candidates
-
-| File | Status | Action |
-|------|--------|--------|
-| `settings.tsx` (root) | Superseded by `settings/SettingsPanel.tsx` | Delete |
-| `AgentActivityFeed.tsx` | Orphaned, replaced by `AgentTimeline.tsx` | Merge unique features into AgentTimeline, then delete |
-| `futureFeatures.tsx` | Orphaned, never rendered | Wire into UI or delete |
-| `extensions.tsx` | Orphaned, uses mock data | Wire into MCP/Agent management or delete |
-| `userMessageTest.tsx` | Test harness, not needed in prod | Move to test directory or delete |
-| `thinkingExample.tsx` | Example file, not needed in prod | Move to test directory or delete |
-| `thinkingTest.tsx` | Test file, not needed in prod | Move to test directory or delete |
-| `THINKING_COMPONENT.md` | Documentation in components dir | Move to docs/ |
-| `errorBoundry.tsx` | Typo in filename | Rename to `errorBoundary.tsx` |
-
----
-
 ## Appendix: Full Wiring Map
 
 ### Extension Handler → Webview Store/Component Mapping

src/services/deep-terminal.service.ts

@@ -546,10 +546,10 @@ export class DeepTerminalService extends EventEmitter {
    * @param id  Session identifier.
    * @returns Concatenated new output, or an empty string if none.
    */
-  public readOutput(id: string): string {
+  public readOutput(id: string): string | null {
     const session = this.sessions.get(id);
     if (!session) {
-      return `Session ${id} not found.`;
+      return null;
     }
 
     const newLines = session.outputBuffer.slice(session.lastReadIndex);
@@ -567,14 +567,29 @@ export class DeepTerminalService extends EventEmitter {
    *
    * @param id  Session identifier.
    */
-  public getFullHistory(id: string): string {
+  public getFullHistory(id: string): string | null {
     const session = this.sessions.get(id);
     if (!session) {
-      return `Session ${id} not found.`;
+      return null;
     }
     return session.outputBuffer.toArray().join("");
   }
 
+  /**
+   * Returns metadata for all active sessions (for webview display).
+   */
+  public listSessions(): Array<{
+    id: string;
+    createdAt: number;
+    bufferSize: number;
+  }> {
+    return [...this.sessions.entries()].map(([id, s]) => ({
+      id,
+      createdAt: s.createdAt,
+      bufferSize: s.outputBuffer.length,
+    }));
+  }
+
   /**
    * Kills the session's child process and removes it from the registry.
    *

src/test/suite/deep-terminal.service.test.ts

@@ -507,9 +507,9 @@ suite("DeepTerminalService — lifecycle", () => {
     assert.strictEqual(service.readOutput("ro1"), "");
   });
 
-  test("readOutput returns not-found for missing session", () => {
+  test("readOutput returns null for missing session", () => {
     const out = service.readOutput("missing");
-    assert.ok(out.includes("not found"));
+    assert.strictEqual(out, null);
   });
 
   test("singleton identity", () => {

src/test/suite/terminal-viewer-handler.test.ts

@@ -0,0 +1,183 @@
+import * as assert from "assert";
+import * as sinon from "sinon";
+import { TerminalViewerHandler } from "../../webview-providers/handlers/terminal-viewer-handler";
+import { HandlerContext } from "../../webview-providers/handlers/types";
+import { DeepTerminalService } from "../../services/deep-terminal.service";
+
+suite("TerminalViewerHandler", () => {
+  let handler: TerminalViewerHandler;
+  let ctx: HandlerContext;
+  let postMessageStub: sinon.SinonStub;
+  let serviceStub: sinon.SinonStubbedInstance<DeepTerminalService>;
+
+  setup(() => {
+    handler = new TerminalViewerHandler();
+
+    postMessageStub = sinon.stub().resolves(true);
+    ctx = {
+      webview: { webview: { postMessage: postMessageStub } },
+      logger: { warn: sinon.stub(), info: sinon.stub(), error: sinon.stub() },
+      extensionUri: {} as any,
+      sendResponse: sinon.stub(),
+    } as unknown as HandlerContext;
+
+    serviceStub = sinon.createStubInstance(DeepTerminalService);
+    sinon.stub(DeepTerminalService, "getInstance").returns(serviceStub as any);
+  });
+
+  teardown(() => {
+    sinon.restore();
+  });
+
+  // ── commands ────────────────────────────────────────────────────
+
+  test("registers all three terminal commands", () => {
+    assert.ok(handler.commands.includes("terminal-list-sessions"));
+    assert.ok(handler.commands.includes("terminal-session-history"));
+    assert.ok(handler.commands.includes("terminal-session-output"));
+    assert.strictEqual(handler.commands.length, 3);
+  });
+
+  // ── terminal-list-sessions ─────────────────────────────────────
+
+  test("list-sessions posts empty array when no sessions", async () => {
+    serviceStub.listSessions.returns([]);
+
+    await handler.handle({ command: "terminal-list-sessions" }, ctx);
+
+    assert.ok(postMessageStub.calledOnce);
+    const msg = postMessageStub.firstCall.args[0];
+    assert.strictEqual(msg.type, "terminal-list-sessions-result");
+    assert.deepStrictEqual(msg.sessions, []);
+  });
+
+  test("list-sessions posts session array", async () => {
+    const sessions = [
+      { id: "s1", createdAt: 1000, bufferSize: 100 },
+      { id: "s2", createdAt: 2000, bufferSize: 200 },
+    ];
+    serviceStub.listSessions.returns(sessions);
+
+    await handler.handle({ command: "terminal-list-sessions" }, ctx);
+
+    assert.ok(postMessageStub.calledOnce);
+    const msg = postMessageStub.firstCall.args[0];
+    assert.strictEqual(msg.type, "terminal-list-sessions-result");
+    assert.deepStrictEqual(msg.sessions, sessions);
+  });
+
+  // ── terminal-session-history ───────────────────────────────────
+
+  test("history returns full output for valid session", async () => {
+    serviceStub.getFullHistory.returns("$ echo hello\nhello\n");
+
+    await handler.handle(
+      { command: "terminal-session-history", sessionId: "s1" },
+      ctx,
+    );
+
+    assert.ok(postMessageStub.calledOnce);
+    const msg = postMessageStub.firstCall.args[0];
+    assert.strictEqual(msg.type, "terminal-session-history-result");
+    assert.strictEqual(msg.sessionId, "s1");
+    assert.strictEqual(msg.output, "$ echo hello\nhello\n");
+  });
+
+  test("history returns error for missing session", async () => {
+    serviceStub.getFullHistory.returns(null);
+
+    await handler.handle(
+      { command: "terminal-session-history", sessionId: "missing" },
+      ctx,
+    );
+
+    assert.ok(postMessageStub.calledOnce);
+    const msg = postMessageStub.firstCall.args[0];
+    assert.strictEqual(msg.type, "terminal-error");
+    assert.strictEqual(msg.sessionId, "missing");
+    assert.ok(msg.error.includes("not found"));
+  });
+
+  test("history returns error for empty sessionId", async () => {
+    await handler.handle(
+      { command: "terminal-session-history", sessionId: "  " },
+      ctx,
+    );
+
+    assert.ok(postMessageStub.calledOnce);
+    const msg = postMessageStub.firstCall.args[0];
+    assert.strictEqual(msg.type, "terminal-error");
+    assert.strictEqual(msg.sessionId, null);
+    assert.ok(msg.error.includes("Invalid"));
+  });
+
+  test("history returns error for non-string sessionId", async () => {
+    await handler.handle(
+      { command: "terminal-session-history", sessionId: 123 } as any,
+      ctx,
+    );
+
+    assert.ok(postMessageStub.calledOnce);
+    const msg = postMessageStub.firstCall.args[0];
+    assert.strictEqual(msg.type, "terminal-error");
+  });
+
+  // ── terminal-session-output ────────────────────────────────────
+
+  test("output returns new data for valid session", async () => {
+    serviceStub.readOutput.returns("new chunk");
+
+    await handler.handle(
+      { command: "terminal-session-output", sessionId: "s1" },
+      ctx,
+    );
+
+    assert.ok(postMessageStub.calledOnce);
+    const msg = postMessageStub.firstCall.args[0];
+    assert.strictEqual(msg.type, "terminal-session-output-result");
+    assert.strictEqual(msg.sessionId, "s1");
+    assert.strictEqual(msg.output, "new chunk");
+  });
+
+  test("output returns error for missing session", async () => {
+    serviceStub.readOutput.returns(null);
+
+    await handler.handle(
+      { command: "terminal-session-output", sessionId: "gone" },
+      ctx,
+    );
+
+    assert.ok(postMessageStub.calledOnce);
+    const msg = postMessageStub.firstCall.args[0];
+    assert.strictEqual(msg.type, "terminal-error");
+    assert.strictEqual(msg.sessionId, "gone");
+    assert.ok(msg.error.includes("not found"));
+  });
+
+  test("output returns error for empty sessionId", async () => {
+    await handler.handle(
+      { command: "terminal-session-output", sessionId: "" },
+      ctx,
+    );
+
+    assert.ok(postMessageStub.calledOnce);
+    const msg = postMessageStub.firstCall.args[0];
+    assert.strictEqual(msg.type, "terminal-error");
+    assert.strictEqual(msg.sessionId, null);
+  });
+
+  // ── unknown / malformed ────────────────────────────────────────
+
+  test("ignores unrelated commands", async () => {
+    await handler.handle({ command: "some-other-command" }, ctx);
+    assert.ok(postMessageStub.notCalled);
+  });
+
+  test("ignores malformed messages", async () => {
+    await handler.handle({} as any, ctx);
+    assert.ok(postMessageStub.notCalled);
+
+    await handler.handle({ command: 123 } as any, ctx);
+    assert.ok(postMessageStub.notCalled);
+  });
+});

src/webview-providers/base.ts

@@ -54,8 +54,8 @@ import { type ProviderKey, toProviderKey } from "./provider-name";
 import {
   BrowserHandler,
   ComposerHandler,
-  ConnectorHandler,
   CostTrackingHandler,
+  TerminalViewerHandler,
   SkillHandler,
   DiffReviewHandler,
   CheckpointHandler,
@@ -241,7 +241,6 @@ export abstract class BaseWebViewProvider implements vscode.Disposable {
     );
     this.handlerRegistry.register(new DockerHandler());
     this.handlerRegistry.register(new MCPHandler());
-    this.handlerRegistry.register(new ConnectorHandler());
     this.handlerRegistry.register(new SkillHandler());
     this.handlerRegistry.register(
       new NewsHandler(() => this.synchronizeNews()),
@@ -272,6 +271,7 @@ export abstract class BaseWebViewProvider implements vscode.Disposable {
     this.handlerRegistry.register(new StandupHandler());
     this.handlerRegistry.register(new TeamGraphHandler());
     this.handlerRegistry.register(new CostTrackingHandler());
+    this.handlerRegistry.register(new TerminalViewerHandler());
     this.handlerRegistry.register(new DoctorHandler());
     this.handlerRegistry.register(new OnboardingHandler());
     this.handlerRegistry.register(

src/webview-providers/handlers/index.ts

@@ -6,7 +6,6 @@ export {
 export { SettingsHandler } from "./settings-handler";
 export { DockerHandler } from "./docker-handler";
 export { MCPHandler } from "./mcp-handler";
-export { ConnectorHandler } from "./connector-handler";
 export { SkillHandler } from "./skill-handler";
 export { NewsHandler } from "./news-handler";
 export { BrowserHandler } from "./browser-handler";
@@ -21,5 +20,6 @@ export { ComposerHandler } from "./composer-handler";
 export { StandupHandler } from "./standup-handler";
 export { TeamGraphHandler } from "./team-graph-handler";
 export { CostTrackingHandler } from "./cost-tracking-handler";
+export { TerminalViewerHandler } from "./terminal-viewer-handler";
 export { DoctorHandler } from "./doctor-handler";
 export { OnboardingHandler } from "./onboarding-handler";

src/webview-providers/handlers/onboarding-handler.ts

@@ -66,6 +66,7 @@ function isOnboardingMessage(msg: unknown): msg is OnboardingMessage {
 
 interface OnboardingStateDTO {
   shouldShow: boolean;
+  completed: boolean;
   providers: Array<{
     id: string;
     name: string;
@@ -94,16 +95,14 @@ export class OnboardingHandler implements WebviewMessageHandler {
         try {
           const shouldShow = svc.shouldShowOnboarding();
           const providers = svc.getProviders();
-          let projectInfo: ProjectInfo | null = null;
-          let suggestedTasks: Array<{ label: string; prompt: string }> = [];
 
-          if (shouldShow) {
-            projectInfo = await svc.detectProjectInfo();
-            suggestedTasks = svc.getSuggestedTasks(projectInfo);
-          }
+          // Always detect project info so the WelcomeScreen can show it
+          const projectInfo = await svc.detectProjectInfo();
+          const suggestedTasks = svc.getSuggestedTasks(projectInfo);
 
           const dto: OnboardingStateDTO = {
             shouldShow,
+            completed: !shouldShow,
             providers,
             projectInfo,
             suggestedTasks,
@@ -121,6 +120,7 @@ export class OnboardingHandler implements WebviewMessageHandler {
             command: "onboarding-state",
             data: {
               shouldShow: false,
+              completed: false,
               providers: [],
               projectInfo: null,
               suggestedTasks: [],