Skip to content

refactor: opinionated tweaks to pystapi-client tests#92

Merged
gadomski merged 3 commits into
mainfrom
client-refactor
Apr 7, 2025
Merged

refactor: opinionated tweaks to pystapi-client tests#92
gadomski merged 3 commits into
mainfrom
client-refactor

Conversation

@gadomski
Copy link
Copy Markdown
Member

@gadomski gadomski commented Apr 7, 2025

What I'm changing

  • Tweak some import styles to @gadomski's preference (classes imported directly)
  • Rename mocked_api to api since it's unlikely we'll ever have a real API in the test suite
  • Use http://stapi.test instead of https://stapi.example.com (@gadomski prefers .test to make it clear that urls are for a test case ... example.com actually resolves to something, wheras .test never will)

Checklist

  • Tests pass: uv run pytest
  • Checks pass: uv run pre-commit --all-files

@gadomski gadomski self-assigned this Apr 7, 2025
@gadomski gadomski merged commit f655ca2 into main Apr 7, 2025
4 checks passed
@gadomski gadomski deleted the client-refactor branch April 7, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant