replace strndup with characterstring_value_const

stargieg · stargieg · commit 51442fb1d97a · 2026-07-07T12:48:10.000+02:00
diff --git a/apps/server-uci/bacnet/basic/object/bi.c b/apps/server-uci/bacnet/basic/object/bi.c
@@ -664,7 +664,7 @@ bool Binary_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
                 if (Binary_Name_Set(
                     pObject, value.type.Character_String.value, Object_Type, wp_data->object_instance)) {
                     ucix_add_option(ctxw, sec, idx_c, "name",
-                        strndup(value.type.Character_String.value,value.type.Character_String.length));
+                        characterstring_value_const(&value.type.Character_String));
                     ucix_commit(ctxw,sec);
                 }
             }
diff --git a/apps/server-uci/bacnet/basic/object/bo.c b/apps/server-uci/bacnet/basic/object/bo.c
@@ -695,7 +695,7 @@ bool Binary_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
                 if (Binary_Name_Set(
                     pObject, value.type.Character_String.value, Object_Type, wp_data->object_instance)) {
                     ucix_add_option(ctxw, sec, idx_c, "name",
-                        strndup(value.type.Character_String.value,value.type.Character_String.length));
+                        characterstring_value_const(&value.type.Character_String));
                     ucix_commit(ctxw,sec);
                 }
             }
diff --git a/apps/server-uci/bacnet/basic/object/bv.c b/apps/server-uci/bacnet/basic/object/bv.c
@@ -666,7 +666,7 @@ bool Binary_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
                 if (Binary_Name_Set(
                     pObject, value.type.Character_String.value, Object_Type, wp_data->object_instance)) {
                     ucix_add_option(ctxw, sec, idx_c, "name",
-                        strndup(value.type.Character_String.value,value.type.Character_String.length));
+                        characterstring_value_const(&value.type.Character_String));
                     ucix_commit(ctxw,sec);
                 }
             }
diff --git a/apps/server-uci/bacnet/basic/object/device.c b/apps/server-uci/bacnet/basic/object/device.c
@@ -3497,7 +3497,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
                 } else {
                     if (Device_Set_Object_Name(&value.type.Character_String)) {
                         ucix_add_option(ctxw, sec, idx_c, "Name",
-                            strndup(value.type.Character_String.value,value.type.Character_String.length));
+                            characterstring_value_const(&value.type.Character_String));
                         ucix_commit(ctxw,sec);
                     }
                 }
diff --git a/apps/server-uci/bacnet/basic/object/ms-input.c b/apps/server-uci/bacnet/basic/object/ms-input.c
@@ -724,7 +724,7 @@ bool Multistate_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
                     pObject, value.type.Character_String.value,
                     Object_Type,wp_data->object_instance)) {
                     ucix_add_option(ctxw, sec, idx_c, "name",
-                        strndup(value.type.Character_String.value,value.type.Character_String.length));
+                        characterstring_value_const(&value.type.Character_String));
                     ucix_commit(ctxw,sec);
                 }
             }
diff --git a/apps/server-uci/bacnet/basic/object/mso.c b/apps/server-uci/bacnet/basic/object/mso.c
@@ -729,7 +729,7 @@ bool Multistate_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
                     pObject, value.type.Character_String.value,
                     Object_Type,wp_data->object_instance)) {
                     ucix_add_option(ctxw, sec, idx_c, "name",
-                        strndup(value.type.Character_String.value,value.type.Character_String.length));
+                        characterstring_value_const(&value.type.Character_String));
                     ucix_commit(ctxw,sec);
                 }
             }
diff --git a/apps/server-uci/bacnet/basic/object/msv.c b/apps/server-uci/bacnet/basic/object/msv.c
@@ -724,7 +724,7 @@ bool Multistate_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
                     pObject, value.type.Character_String.value,
                     Object_Type,wp_data->object_instance)) {
                     ucix_add_option(ctxw, sec, idx_c, "name",
-                        strndup(value.type.Character_String.value,value.type.Character_String.length));
+                        characterstring_value_const(&value.type.Character_String));
                     ucix_commit(ctxw,sec);
                 }
             }
diff --git a/apps/server-uci/bacnet/basic/object/nc.c b/apps/server-uci/bacnet/basic/object/nc.c
@@ -947,7 +947,7 @@ bool Notification_Class_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
                     Object_Type,
                     wp_data->object_instance)) {
                     ucix_add_option(ctxw, sec, idx_c, "name",
-                        strndup(value.type.Character_String.value,value.type.Character_String.length));
+                        characterstring_value_const(&value.type.Character_String));
                     ucix_commit(ctxw,sec);
                 }
             }
diff --git a/apps/server-uci/bacnet/basic/object/schedule.c b/apps/server-uci/bacnet/basic/object/schedule.c
@@ -1289,7 +1289,7 @@ bool Schedule_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
                     Object_Type,
                     wp_data->object_instance)) {
                     ucix_add_option(ctxw, sec, idx_c, "name",
-                        strndup(value.type.Character_String.value,value.type.Character_String.length));
+                        characterstring_value_const(&value.type.Character_String));
                     ucix_commit(ctxw,sec);
                 }
             }
diff --git a/apps/server-uci/bacnet/basic/object/trendlog.c b/apps/server-uci/bacnet/basic/object/trendlog.c
@@ -1066,7 +1066,7 @@ bool Trend_Log_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
                     Object_Type,
                     wp_data->object_instance)) {
                     ucix_add_option(ctxw, sec, idx_c, "name",
-                        strndup(value.type.Character_String.value,value.type.Character_String.length));
+                        characterstring_value_const(&value.type.Character_String));
                     ucix_commit(ctxw,sec);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -664,7 +664,7 @@ bool Binary_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`664`	`664`	`if (Binary_Name_Set(`
`665`	`665`	`pObject, value.type.Character_String.value, Object_Type, wp_data->object_instance)) {`
`666`	`666`	`ucix_add_option(ctxw, sec, idx_c, "name",`
`667`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`667`	`+ characterstring_value_const(&value.type.Character_String));`
`668`	`668`	`ucix_commit(ctxw,sec);`
`669`	`669`	`}`
`670`	`670`	`}`
Original file line number	Diff line number	Diff line change
`@@ -695,7 +695,7 @@ bool Binary_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`695`	`695`	`if (Binary_Name_Set(`
`696`	`696`	`pObject, value.type.Character_String.value, Object_Type, wp_data->object_instance)) {`
`697`	`697`	`ucix_add_option(ctxw, sec, idx_c, "name",`
`698`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`698`	`+ characterstring_value_const(&value.type.Character_String));`
`699`	`699`	`ucix_commit(ctxw,sec);`
`700`	`700`	`}`
`701`	`701`	`}`
Original file line number	Diff line number	Diff line change
`@@ -666,7 +666,7 @@ bool Binary_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`666`	`666`	`if (Binary_Name_Set(`
`667`	`667`	`pObject, value.type.Character_String.value, Object_Type, wp_data->object_instance)) {`
`668`	`668`	`ucix_add_option(ctxw, sec, idx_c, "name",`
`669`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`669`	`+ characterstring_value_const(&value.type.Character_String));`
`670`	`670`	`ucix_commit(ctxw,sec);`
`671`	`671`	`}`
`672`	`672`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3497,7 +3497,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`3497`	`3497`	`} else {`
`3498`	`3498`	`if (Device_Set_Object_Name(&value.type.Character_String)) {`
`3499`	`3499`	`ucix_add_option(ctxw, sec, idx_c, "Name",`
`3500`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`3500`	`+ characterstring_value_const(&value.type.Character_String));`
`3501`	`3501`	`ucix_commit(ctxw,sec);`
`3502`	`3502`	`}`
`3503`	`3503`	`}`
Original file line number	Diff line number	Diff line change
`@@ -724,7 +724,7 @@ bool Multistate_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`724`	`724`	`pObject, value.type.Character_String.value,`
`725`	`725`	`Object_Type,wp_data->object_instance)) {`
`726`	`726`	`ucix_add_option(ctxw, sec, idx_c, "name",`
`727`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`727`	`+ characterstring_value_const(&value.type.Character_String));`
`728`	`728`	`ucix_commit(ctxw,sec);`
`729`	`729`	`}`
`730`	`730`	`}`
Original file line number	Diff line number	Diff line change
`@@ -729,7 +729,7 @@ bool Multistate_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`729`	`729`	`pObject, value.type.Character_String.value,`
`730`	`730`	`Object_Type,wp_data->object_instance)) {`
`731`	`731`	`ucix_add_option(ctxw, sec, idx_c, "name",`
`732`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`732`	`+ characterstring_value_const(&value.type.Character_String));`
`733`	`733`	`ucix_commit(ctxw,sec);`
`734`	`734`	`}`
`735`	`735`	`}`
Original file line number	Diff line number	Diff line change
`@@ -724,7 +724,7 @@ bool Multistate_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`724`	`724`	`pObject, value.type.Character_String.value,`
`725`	`725`	`Object_Type,wp_data->object_instance)) {`
`726`	`726`	`ucix_add_option(ctxw, sec, idx_c, "name",`
`727`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`727`	`+ characterstring_value_const(&value.type.Character_String));`
`728`	`728`	`ucix_commit(ctxw,sec);`
`729`	`729`	`}`
`730`	`730`	`}`
Original file line number	Diff line number	Diff line change
`@@ -947,7 +947,7 @@ bool Notification_Class_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`947`	`947`	`Object_Type,`
`948`	`948`	`wp_data->object_instance)) {`
`949`	`949`	`ucix_add_option(ctxw, sec, idx_c, "name",`
`950`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`950`	`+ characterstring_value_const(&value.type.Character_String));`
`951`	`951`	`ucix_commit(ctxw,sec);`
`952`	`952`	`}`
`953`	`953`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1289,7 +1289,7 @@ bool Schedule_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`1289`	`1289`	`Object_Type,`
`1290`	`1290`	`wp_data->object_instance)) {`
`1291`	`1291`	`ucix_add_option(ctxw, sec, idx_c, "name",`
`1292`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`1292`	`+ characterstring_value_const(&value.type.Character_String));`
`1293`	`1293`	`ucix_commit(ctxw,sec);`
`1294`	`1294`	`}`
`1295`	`1295`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1066,7 +1066,7 @@ bool Trend_Log_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)`
`1066`	`1066`	`Object_Type,`
`1067`	`1067`	`wp_data->object_instance)) {`
`1068`	`1068`	`ucix_add_option(ctxw, sec, idx_c, "name",`
`1069`		`- strndup(value.type.Character_String.value,value.type.Character_String.length));`
	`1069`	`+ characterstring_value_const(&value.type.Character_String));`
`1070`	`1070`	`ucix_commit(ctxw,sec);`
`1071`	`1071`	`}`
`1072`	`1072`	`}`