Refactored argument parser setup in consumer module; replaced global parser with a build_parser function. Updated tests and mocks to use the new parser structure.

Author: starichkov

consumer.py

@@ -11,11 +11,14 @@
 import argparse
 import json
 
-parser = argparse.ArgumentParser(description="Kafka Event Consumer")
-parser.add_argument("-e", "--event-type", help="Filter by event_type (optional)", required=False)
-parser.add_argument("-g", "--group-id", help="Kafka consumer group ID (optional)", required=False)
-parser.add_argument("-t", "--test-mode", action="store_true")
-args = parser.parse_args()
+
+def build_parser():
+    """Build and return the argument parser for the consumer CLI."""
+    parser = argparse.ArgumentParser(description="Kafka Event Consumer")
+    parser.add_argument("-e", "--event-type", help="Filter by event_type (optional)", required=False)
+    parser.add_argument("-g", "--group-id", help="Kafka consumer group ID (optional)", required=False)
+    parser.add_argument("-t", "--test-mode", action="store_true")
+    return parser
 
 """
 Apache Kafka Consumer Demo
@@ -98,6 +101,9 @@ def consume_events(topic, consumer_args, event_type=None, group_id=None):
 
 def main():
     """Main function that runs when the script is executed directly"""
+    parser = build_parser()
+    args = parser.parse_args()
+
     kafka_topic = os.environ.get("KAFKA_TOPIC", "test-topic")
     kafka_bootstrap_servers = os.environ.get("KAFKA_BOOTSTRAP_SERVERS", "localhost:9092")
 

run_tests_with_coverage.sh

@@ -1,7 +1,7 @@
 #export COVERAGE_PROCESS_START=$(pwd)/.coveragerc
 rm -r htmlcov/
-rm .coverage
-rm .coverage.*
+rm -f .coverage
+rm -f .coverage.*
 pytest --cov --cov-report=term-missing
 coverage html
 #xdg-open htmlcov/index.html

tests/test_integration.py

@@ -450,7 +450,8 @@ def test_coverage_startup_producer(self, mock_process_startup):
 
     def test_consumer_argument_parser_setup(self):
         """Test that the consumer argument parser is properly configured"""
-        parser_actions = [action.dest for action in consumer.parser._actions]
+        parser = consumer.build_parser()
+        parser_actions = [action.dest for action in parser._actions]
 
         assert 'event_type' in parser_actions
         assert 'group_id' in parser_actions
@@ -480,8 +481,9 @@ class TestArgumentParsingIntegration:
 
     def test_consumer_with_all_arguments(self):
         """Test consumer argument parsing with all options"""
-        from consumer import parser
+        from consumer import build_parser
 
+        parser = build_parser()
         args = parser.parse_args([
             '--event-type', 'test_event',
             '--group-id', 'test_group',
@@ -494,8 +496,9 @@ def test_consumer_with_all_arguments(self):
 
     def test_consumer_with_no_arguments(self):
         """Test consumer argument parsing with no arguments"""
-        from consumer import parser
+        from consumer import build_parser
 
+        parser = build_parser()
         args = parser.parse_args([])
 
         assert args.event_type is None
@@ -529,11 +532,12 @@ def test_main_function_execution(self, mock_consume_events):
     @patch.dict(os.environ, {'KAFKA_TOPIC': 'custom-topic', 'KAFKA_BOOTSTRAP_SERVERS': 'custom:9092'})
     def test_main_function_with_arguments_and_custom_env(self, mock_consume_events):
         """Test main function execution with custom environment variables and arguments"""
-        # Mock the args object directly instead of reloading
-        with patch('consumer.args') as mock_args:
-            mock_args.group_id = 'test-group'
-            mock_args.event_type = 'test-event'
-            mock_args.test_mode = False
+        # Mock the parser to control parsed args
+        with patch('consumer.build_parser') as mock_build_parser:
+            from types import SimpleNamespace
+            mock_parser = Mock()
+            mock_parser.parse_args.return_value = SimpleNamespace(group_id='test-group', event_type='test-event', test_mode=False)
+            mock_build_parser.return_value = mock_parser
 
             consumer.main()
 
@@ -550,11 +554,12 @@ def test_main_function_with_arguments_and_custom_env(self, mock_consume_events):
     @patch('consumer.consume_events')
     def test_main_function_with_test_mode(self, mock_consume_events):
         """Test main function execution with test mode argument"""
-        # Mock the args object to simulate test mode
-        with patch('consumer.args') as mock_args:
-            mock_args.group_id = None
-            mock_args.event_type = None
-            mock_args.test_mode = True
+        # Mock the parser to simulate test mode via parsed args
+        with patch('consumer.build_parser') as mock_build_parser:
+            from types import SimpleNamespace
+            mock_parser = Mock()
+            mock_parser.parse_args.return_value = SimpleNamespace(group_id=None, event_type=None, test_mode=True)
+            mock_build_parser.return_value = mock_parser
 
             consumer.main()