Fix Juicity pinned cert chain

Author: starifly

app/src/main/java/io/nekohasekai/sagernet/fmt/juicity/JuicityFmt.kt

@@ -6,7 +6,9 @@ import io.nekohasekai.sagernet.ktx.toLink
 import io.nekohasekai.sagernet.ktx.urlSafe
 import moe.matsuri.nb4a.SingBoxOptions
 import moe.matsuri.nb4a.SingBoxOptions.Outbound_JuicityOptions
+import moe.matsuri.nb4a.utils.listByLineOrComma
 import okhttp3.HttpUrl.Companion.toHttpUrlOrNull
+import java.util.Base64
 
 fun parseJuicity(url: String): JuicityBean {
     val link = url.replace("juicity://", "https://").toHttpUrlOrNull() ?: error(
@@ -23,7 +25,9 @@ fun parseJuicity(url: String): JuicityBean {
             sni = it
         }
         link.queryParameter("pinned_certchain_sha256")?.let {
-            pinnedCertchainSha256 = it
+            normalizePinnedCertChainHash(it)?.let { hash ->
+                pinnedCertchainSha256 = hash
+            }
         }
         link.queryParameter("allow_insecure")?.let {
             if (it == "1" || it == "true") allowInsecure = true
@@ -38,7 +42,9 @@ fun JuicityBean.toUri(): String {
         builder.addQueryParameter("sni", sni)
     }
     if (pinnedCertchainSha256.isNotBlank()) {
-        builder.addQueryParameter("pinned_certchain_sha256", pinnedCertchainSha256)
+        normalizePinnedCertChainHash(pinnedCertchainSha256.listByLineOrComma().firstOrNull())?.let {
+            builder.addQueryParameter("pinned_certchain_sha256", it)
+        }
     }
     if (allowInsecure) {
         builder.addQueryParameter("allow_insecure", "1")
@@ -68,7 +74,18 @@ fun buildSingBoxOutboundJuicityBean(bean: JuicityBean): Outbound_JuicityOptions
         }
 
         if (bean.pinnedCertchainSha256.isNotBlank()) {
-            pin_cert_sha256 = bean.pinnedCertchainSha256
+            normalizePinnedCertChainHash(bean.pinnedCertchainSha256.listByLineOrComma().firstOrNull())?.let {
+                pin_cert_sha256 = it
+            }
         }
     }
 }
+
+private fun normalizePinnedCertChainHash(rawHash: String?): String? {
+    val certChainHash = rawHash?.replace(":", "")?.takeIf { it.isNotEmpty() } ?: return null
+    return when {
+        certChainHash.length == 64 -> Base64.getUrlEncoder()
+            .encodeToString(certChainHash.chunked(2).map { chunk -> chunk.toInt(16).toByte() }.toByteArray())
+        else -> certChainHash.replace('/', '_').replace('+', '-')
+    }
+}

libcore/protocol/juicity/outbound.go

@@ -3,8 +3,8 @@ package juicity
 import (
 	"bytes"
 	"context"
+	"crypto/sha256"
 	"crypto/x509"
-  "crypto/sha256"
 	"encoding/base64"
 	"encoding/hex"
 	"net"
@@ -16,12 +16,12 @@ import (
 	"github.com/sagernet/sing-box/common/tls"
 	C "github.com/sagernet/sing-box/constant"
 	"github.com/sagernet/sing-box/log"
+	"github.com/sagernet/sing-box/option"
 	"github.com/sagernet/sing/common/bufio"
 	E "github.com/sagernet/sing/common/exceptions"
 	"github.com/sagernet/sing/common/logger"
 	M "github.com/sagernet/sing/common/metadata"
 	N "github.com/sagernet/sing/common/network"
-	"github.com/sagernet/sing-box/option"
 
 	"github.com/dyhkwong/sing-juicity"
 	"github.com/gofrs/uuid/v5"
@@ -156,18 +156,16 @@ func tryDecodeBase64(raw string) ([]byte, error) {
 	return nil, E.Cause(E.Errors(errors...), "try decoding base64")
 }
 
-// Simple implementation of cert chain hash - you may need to adjust this
-func certChainHash(rawCerts [][]byte) (hash []byte) {
-	// This is a simplified implementation. You might need to implement
-	// the exact hash calculation method used by juicity
-	// For now, return the first cert's hash as placeholder
-	// if len(rawCerts) > 0 {
-	// 	return rawCerts[0][:32] // simplified
-	// }
-	// return nil
-  for _, cert := range rawCerts {
-    sum := sha256.Sum256(cert)
-    hash = append(hash, sum[:]...)
-  }
-  return
+func certChainHash(rawCerts [][]byte) []byte {
+	var chainHash []byte
+	for _, cert := range rawCerts {
+		certHash := sha256.Sum256(cert)
+		if chainHash == nil {
+			chainHash = certHash[:]
+		} else {
+			newHash := sha256.Sum256(append(chainHash, certHash[:]...))
+			chainHash = newHash[:]
+		}
+	}
+	return chainHash
 }