Skip to content

update commit in upload_artifacts_workflow#382

Open
noa-starkware wants to merge 1 commit into
mainfrom
noa/update-commit-upload_artifacts_workflow
Open

update commit in upload_artifacts_workflow#382
noa-starkware wants to merge 1 commit into
mainfrom
noa/update-commit-upload_artifacts_workflow

Conversation

@noa-starkware

@noa-starkware noa-starkware commented Jul 5, 2026

Copy link
Copy Markdown

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@cursor

cursor Bot commented Jul 5, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Dependency pin affects proving/Cairo stacks across the workspace; the workflow hardcodes commit SHA and a non-main branch, which is risky if merged without reverting to github.sha and main.

Overview
Bumps all workspace stwo-cairo git dependencies from 68b4af6d to 971de93b456248b1b073a130625b9df8520a1a29 in Cargo.toml, with matching Cargo.lock updates (including duplicate package entries where transitive deps still pull the older rev).

Upload-Artifacts workflow changes: push trigger adds branch noa/update-commit-upload_artifacts_workflow, and COMMIT_SHA is set to a fixed hash (89155aa…) instead of ${{ github.sha }}, so GCS paths use that commit’s short prefix when publishing binaries.

Reviewed by Cursor Bugbot for commit 4ce1601. Bugbot is set up for automated code reviews on this repo. Configure here.

- name: Get commit hash prefix for PR update
env:
COMMIT_SHA: ${{ github.sha }}
COMMIT_SHA: 89155aade81a2727937d1734a117b118ec97540b

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded commit breaks artifact paths

High Severity

Replacing ${{ github.sha }} with a fixed full commit hash makes SHORT_HASH always 89155aa on every main push, while actions/checkout still builds the triggering commit. Binaries upload under a stale path prefix, so consumers cannot rely on GCS destinations matching the commit that built the artifacts.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8c23f7f. Configure here.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.28%. Comparing base (b6fe5d3) to head (4ce1601).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   65.28%   65.28%           
=======================================
  Files          39       39           
  Lines        5641     5641           
=======================================
  Hits         3683     3683           
  Misses       1958     1958           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noa-starkware noa-starkware force-pushed the noa/update-commit-upload_artifacts_workflow branch from 8c23f7f to 8f0a55f Compare July 5, 2026 12:37
@noa-starkware noa-starkware force-pushed the noa/update-commit-upload_artifacts_workflow branch from 8f0a55f to 4ce1601 Compare July 5, 2026 12:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4ce1601. Configure here.

push:
branches:
- main
- noa/update-commit-upload_artifacts_workflow

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main branch upload trigger removed

High Severity

The workflow’s push trigger no longer includes main and only runs on noa/update-commit-upload_artifacts_workflow. After merge, pushes to main would not run Upload-Artifacts, so release binaries would stop uploading for the primary integration branch.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4ce1601. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant