update commit in upload_artifacts_workflow#382
Conversation
PR SummaryMedium Risk Overview Upload-Artifacts workflow changes: push trigger adds branch Reviewed by Cursor Bugbot for commit 4ce1601. Bugbot is set up for automated code reviews on this repo. Configure here. |
| - name: Get commit hash prefix for PR update | ||
| env: | ||
| COMMIT_SHA: ${{ github.sha }} | ||
| COMMIT_SHA: 89155aade81a2727937d1734a117b118ec97540b |
There was a problem hiding this comment.
Hardcoded commit breaks artifact paths
High Severity
Replacing ${{ github.sha }} with a fixed full commit hash makes SHORT_HASH always 89155aa on every main push, while actions/checkout still builds the triggering commit. Binaries upload under a stale path prefix, so consumers cannot rely on GCS destinations matching the commit that built the artifacts.
Reviewed by Cursor Bugbot for commit 8c23f7f. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
Coverage 65.28% 65.28%
=======================================
Files 39 39
Lines 5641 5641
=======================================
Hits 3683 3683
Misses 1958 1958 🚀 New features to boost your workflow:
|
8c23f7f to
8f0a55f
Compare
8f0a55f to
4ce1601
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4ce1601. Configure here.
| push: | ||
| branches: | ||
| - main | ||
| - noa/update-commit-upload_artifacts_workflow |
There was a problem hiding this comment.
Main branch upload trigger removed
High Severity
The workflow’s push trigger no longer includes main and only runs on noa/update-commit-upload_artifacts_workflow. After merge, pushes to main would not run Upload-Artifacts, so release binaries would stop uploading for the primary integration branch.
Reviewed by Cursor Bugbot for commit 4ce1601. Configure here.


Type
Description
Breaking changes?
This change is