Skip to content

update commit in upload_artifacts_workflow #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noa-starkware wants to merge 1 commit into
base: main
Choose a base branch
from
+165 −42
Open

update commit in upload_artifacts_workflow #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/upload_artifacts_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Upload-Artifacts
on:
push:
branches:
- main
- noa/update-commit-upload_artifacts_workflow

@cursor cursor Bot Jul 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main branch upload trigger removed

High Severity

The workflow’s push trigger no longer includes main and only runs on noa/update-commit-upload_artifacts_workflow. After merge, pushes to main would not run Upload-Artifacts, so release binaries would stop uploading for the primary integration branch.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4ce1601. Configure here.


jobs:
artifacts-push:
Expand All @@ -13,7 +13,7 @@ jobs:

- name: Get commit hash prefix for PR update
env:
COMMIT_SHA: ${{ github.sha }}
COMMIT_SHA: 89155aade81a2727937d1734a117b118ec97540b

@cursor cursor Bot Jul 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded commit breaks artifact paths

High Severity

Replacing ${{ github.sha }} with a fixed full commit hash makes SHORT_HASH always 89155aa on every main push, while actions/checkout still builds the triggering commit. Binaries upload under a stale path prefix, so consumers cannot rely on GCS destinations matching the commit that built the artifacts.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8c23f7f. Configure here.

run: |
echo "SHORT_HASH=${COMMIT_SHA:0:7}" >> $GITHUB_ENV

Expand Down
191 changes: 157 additions & 34 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ cairo-lang-execute-utils = "2.19.0-rc.0"
cairo-lang-utils = "2.19.0-rc.0"

# stwo cairo
cairo-air = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "68b4af6d" }
stwo-cairo-utils = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "68b4af6d" }
stwo-cairo-adapter = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "68b4af6d" }
stwo-cairo-prover = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "68b4af6d" }
stwo-cairo-serialize = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "68b4af6d" }
stwo-cairo-common = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "68b4af6d" }
cairo-air = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "971de93b456248b1b073a130625b9df8520a1a29" }
stwo-cairo-utils = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "971de93b456248b1b073a130625b9df8520a1a29" }
stwo-cairo-adapter = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "971de93b456248b1b073a130625b9df8520a1a29" }
stwo-cairo-prover = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "971de93b456248b1b073a130625b9df8520a1a29" }
stwo-cairo-serialize = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "971de93b456248b1b073a130625b9df8520a1a29" }
stwo-cairo-common = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "971de93b456248b1b073a130625b9df8520a1a29" }


# local crates
Expand Down
Loading