Skip to content

Bump_sc#383

Merged
YairVaknin-starkware merged 1 commit into
mainfrom
yairv/bump_sc
Jul 6, 2026
Merged

Bump_sc#383
YairVaknin-starkware merged 1 commit into
mainfrom
yairv/bump_sc

Conversation

@YairVaknin-starkware

@YairVaknin-starkware YairVaknin-starkware commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@cursor

cursor Bot commented Jul 6, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Proving and Cairo verification behavior can change with the new stwo-cairo commit, and dual revisions in the lockfile increase integration risk until stwo-circuits is bumped.

Overview
Bumps all workspace stwo-cairo git dependencies in Cargo.toml from rev 68b4af6d to ffd4a4e8d101abbf916db1977e2ac32b52b0fbe9 (cairo-air, stwo-cairo-utils, stwo-cairo-adapter, stwo-cairo-prover, stwo-cairo-serialize, stwo-cairo-common). Cargo.lock is regenerated so first-party crates (stwo-run-and-prove, privacy-prove, vm_runner, etc.) resolve against the new revision.

The lockfile still pulls stwo-cairo @ 68b4af6d transitively via stwo-circuits, so the build graph temporarily contains duplicate cairo-air / stwo-cairo-* packages at two commits until that dependency aligns.

Reviewed by Cursor Bugbot for commit 1597d0a. Bugbot is set up for automated code reviews on this repo. Configure here.

@az-starkware az-starkware left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@az-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on YairVaknin-starkware).

@YairVaknin-starkware YairVaknin-starkware enabled auto-merge (squash) July 6, 2026 08:42
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.28%. Comparing base (b6fe5d3) to head (1597d0a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   65.28%   65.28%           
=======================================
  Files          39       39           
  Lines        5641     5641           
=======================================
  Hits         3683     3683           
  Misses       1958     1958           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YairVaknin-starkware YairVaknin-starkware merged commit 0ee1074 into main Jul 6, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants