Skip to content

Commit 03b2fb5

Browse files
committed
apollo_node_config: CR fixes
1 parent 3772cef commit 03b2fb5

1 file changed

Lines changed: 2 additions & 16 deletions

File tree

crates/apollo_node_config/src/node_config.rs

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ use apollo_reverts::RevertConfig;
3939
use apollo_sierra_compilation_config::config::SierraCompilationConfig;
4040
use apollo_staking_config::config::StakingManagerDynamicConfig;
4141
use apollo_state_sync_config::config::{StateSyncConfig, StateSyncDynamicConfig};
42-
use apollo_storage::StorageScope;
4342
use blockifier::blockifier::config::NativeClassesWhitelist;
4443
use blockifier::blockifier_versioned_constants::VersionedConstantsOverrides;
4544
use clap::Command;
@@ -604,21 +603,8 @@ impl SequencerNodeConfig {
604603
}
605604
other => other,
606605
})?;
607-
// TODO(Asaf): validation-only nodes should ideally use StorageScope::StateOnly to
608-
// save disk and write traffic, but the SNIP-35 fee_proposals bootstrap calls
609-
// state_sync.get_block(), which reads transaction_metadata - a table excluded from
610-
// StateOnly (see apollo_storage::StorageScope). Find a way to either (a) make
611-
// get_block work without transaction_metadata or (b) skip the bootstrap call on
612-
// validation-only nodes, then flip this back to requiring StateOnly.
613-
if let Some(state_sync_config) = &self.state_sync_config {
614-
if state_sync_config.static_config.storage_config.scope != StorageScope::FullArchive {
615-
return Err(ConfigError::ComponentConfigMismatch {
616-
component_config_mismatch: "state_sync storage scope must be FullArchive when \
617-
validation_only is true"
618-
.to_string(),
619-
});
620-
}
621-
}
606+
// TODO(Asaf): Revert PR 14122 and require StorageScope::StateOnly here once
607+
// state_sync.get_block() works without transaction_metadata (the orchestrator needs it).
622608
Ok(())
623609
}
624610
}

0 commit comments

Comments
 (0)