apollo_proc_macros: move COLLECT_PROFILING_METRICS out of papyrus_common (#13848)

Author: dorimedini-starkware

Cargo.lock

@@ -1 +1,8 @@
+use std::sync::OnceLock;
+
+// TODO(Shahak): consider making this value non static and add a way to change this while the app is
+// running. e.g via a monitoring endpoint.
+/// Global variable set by the main config to enable collecting profiling metrics.
+pub static COLLECT_PROFILING_METRICS: OnceLock<bool> = OnceLock::new();
+
 pub use apollo_proc_macros_lib::*;

crates/apollo_proc_macros/src/lib.rs

@@ -172,7 +172,7 @@ pub fn latency_histogram(attr: TokenStream, input: TokenStream) -> TokenStream {
     };
 
     let collect_metric_flag = quote! {
-        papyrus_common::metrics::COLLECT_PROFILING_METRICS
+        apollo_proc_macros::COLLECT_PROFILING_METRICS
     };
 
     create_modified_function(

crates/apollo_proc_macros_lib/src/lib.rs

@@ -6,11 +6,14 @@ use apollo_metrics::metrics::{
     MetricScope,
     COLLECT_SEQUENCER_PROFILING_METRICS,
 };
-use apollo_proc_macros::{latency_histogram, sequencer_latency_histogram};
+use apollo_proc_macros::{
+    latency_histogram,
+    sequencer_latency_histogram,
+    COLLECT_PROFILING_METRICS,
+};
 use apollo_test_utils::prometheus_is_contained;
 use metrics::set_default_local_recorder;
 use metrics_exporter_prometheus::PrometheusBuilder;
-use papyrus_common::metrics::COLLECT_PROFILING_METRICS;
 use prometheus_parse::Value::Untyped;
 use rstest::rstest;
 

crates/apollo_proc_macros_tests/tests/latency_histogram.rs

@@ -7,8 +7,8 @@ license-file.workspace = true
 description = "A storage implementation for a Starknet node."
 
 [features]
-testing = ["reqwest", "starknet_api/testing", "tempfile", "tower"]
 storage_cli = ["clap", "reqwest"]
+testing = ["reqwest", "starknet_api/testing", "tempfile", "tower"]
 
 [dependencies]
 apollo_config.workspace = true
@@ -31,14 +31,13 @@ memmap2.workspace = true
 metrics.workspace = true
 num-bigint.workspace = true
 page_size.workspace = true
-papyrus_common.workspace = true
 parity-scale-codec.workspace = true
 primitive-types.workspace = true
 reqwest = { workspace = true, features = ["json"], optional = true }
 serde = { workspace = true, features = ["derive"] }
 serde_json = { workspace = true, features = ["arbitrary_precision"] }
-starknet_api.workspace = true
 starknet-types-core = { workspace = true, features = ["papyrus-serialization"] }
+starknet_api.workspace = true
 tempfile = { workspace = true, optional = true }
 thiserror.workspace = true
 tokio = { workspace = true, features = ["rt-multi-thread"] }
@@ -77,10 +76,6 @@ tower = { workspace = true, features = ["util"] }
 [lints]
 workspace = true
 
-# Used in apollo_proc_macros for latency_histogram.
-[package.metadata.cargo-machete]
-ignored = ["papyrus_common"]
-
 
 [[bin]]
 name = "storage_cli"

crates/apollo_storage/Cargo.toml

@@ -1,5 +1,4 @@
 pub mod deprecated_class_abi;
-pub mod metrics;
 pub mod pending_classes;
 pub mod python_json;
 pub mod state;