Commit 4f5f772
apollo_deployments: retire dead preset/replacer generation machinery
Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so
the preset-replacer GENERATION machinery is dead. Remove it:
- Delete resources/app_configs/replacer_*.json (19 files), src/replacers.rs, and the
deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep).
- service.rs: drop the replacer-annotation plumbing, the deploy-path config_to_preset/
prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep
KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's
exclusion set).
- Delete the 3 migration guard tests (deployment_files_are_up_to_date,
replacer_config_entries_are_in_config, duplicate_config_entries). Keep the
build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards,
and get_component_configs.
The cdk8s configList field is presence-checked only (its targets live in a different
directory and are not read under native), so deleting the base replacer JSONs leaves
synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent a3d7879 commit 4f5f772
28 files changed
Lines changed: 8 additions & 818 deletions
File tree
- crates/apollo_deployments
- resources/app_configs
- src
- bin
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | 29 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
Lines changed: 0 additions & 8 deletions
This file was deleted.
Lines changed: 0 additions & 62 deletions
This file was deleted.
Lines changed: 0 additions & 19 deletions
This file was deleted.
Lines changed: 0 additions & 19 deletions
This file was deleted.
Lines changed: 0 additions & 4 deletions
This file was deleted.
0 commit comments