Skip to content

Commit 4f5f772

Browse files
apollo_deployments: retire dead preset/replacer generation machinery
Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so the preset-replacer GENERATION machinery is dead. Remove it: - Delete resources/app_configs/replacer_*.json (19 files), src/replacers.rs, and the deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep). - service.rs: drop the replacer-annotation plumbing, the deploy-path config_to_preset/ prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's exclusion set). - Delete the 3 migration guard tests (deployment_files_are_up_to_date, replacer_config_entries_are_in_config, duplicate_config_entries). Keep the build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards, and get_component_configs. The cdk8s configList field is presence-checked only (its targets live in a different directory and are not read under native), so deleting the base replacer JSONs leaves synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent a3d7879 commit 4f5f772

28 files changed

Lines changed: 8 additions & 818 deletions

Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/apollo_deployments/Cargo.toml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,4 @@ apollo_infra_utils = { workspace = true, features = ["testing"] }
2626
apollo_node_config = { workspace = true, features = ["testing"] }
2727
jrsonnet-evaluator = { workspace = true }
2828
jrsonnet-stdlib = { workspace = true }
29-
tempfile.workspace = true
3029
url = { workspace = true, features = ["serde"] }
31-
32-
[[bin]]
33-
name = "deployment_generator"
34-
path = "src/bin/deployment_generator.rs"

crates/apollo_deployments/resources/app_configs/replacer_base_layer_config.json

Lines changed: 0 additions & 8 deletions
This file was deleted.

crates/apollo_deployments/resources/app_configs/replacer_batcher_config.json

Lines changed: 0 additions & 62 deletions
This file was deleted.

crates/apollo_deployments/resources/app_configs/replacer_class_manager_config.json

Lines changed: 0 additions & 19 deletions
This file was deleted.

crates/apollo_deployments/resources/app_configs/replacer_committer_config.json

Lines changed: 0 additions & 19 deletions
This file was deleted.

crates/apollo_deployments/resources/app_configs/replacer_config_manager_config.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)