Skip to content

Commit 5a4b997

Browse files
starknet_transaction_prover,ci,scripts: rename crate from starknet_os_runner (#12980)
1 parent 7ad8d0d commit 5a4b997

57 files changed

Lines changed: 136 additions & 134 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.gitattributes

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ crates/blockifier_test_utils/resources/feature_contracts/cairo1/sierra/*.json -d
77
# list of all uncovered hints, which *should* be reviewed.
88
crates/starknet_os/resources/hint_coverage/*.json -diff
99

10-
# Starknet OS runner proving resources - large binary/JSON files.
11-
crates/starknet_os_runner/resources/*.json -diff
12-
crates/starknet_os_runner/resources/*.bin -diff
13-
crates/starknet_os_runner/resources/*.zip -diff
10+
# Starknet tx prover proving resources - large binary/JSON files.
11+
crates/starknet_transaction_prover/resources/*.json -diff
12+
crates/starknet_transaction_prover/resources/*.bin -diff
13+
crates/starknet_transaction_prover/resources/*.zip -diff

.github/workflows/starknet_os_runner_ci.yml renamed to .github/workflows/starknet_transaction_prover_ci.yml

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Starknet-OS-Runner-CI
1+
name: Starknet-Transaction-Prover-CI
22

33
on:
44
pull_request:
@@ -8,17 +8,17 @@ on:
88
- synchronize
99
paths:
1010
- ".github/actions/bootstrap/action.yml"
11-
- ".github/workflows/starknet_os_runner_ci.yml"
11+
- ".github/workflows/starknet_transaction_prover_ci.yml"
1212
- "Cargo.lock"
1313
- "Cargo.toml"
1414
- "crates/blockifier/**"
1515
- "crates/blockifier_reexecution/**"
1616
- "crates/proving_utils/**"
1717
- "crates/starknet_committer/**"
1818
- "crates/starknet_os/**"
19-
- "crates/starknet_os_runner/**"
2019
- "crates/starknet_patricia/**"
21-
- "scripts/build_starknet_os_runner.sh"
20+
- "crates/starknet_transaction_prover/**"
21+
- "scripts/build_starknet_transaction_prover.sh"
2222
- "scripts/dependencies.sh"
2323
- "scripts/requirements.txt"
2424

@@ -37,7 +37,7 @@ permissions:
3737
contents: read
3838

3939
jobs:
40-
starknet_os_runner_ci:
40+
starknet_transaction_prover_ci:
4141
runs-on: namespace-profile-xlarge-ubuntu-24-04-amd64
4242
timeout-minutes: 30
4343
steps:
@@ -65,36 +65,36 @@ jobs:
6565
path: /home/runner/.rustup
6666

6767
# Bootstrap installs the repo-wide stable toolchain (from root rust-toolchain.toml).
68-
# starknet_os_runner has its own rust-toolchain.toml specifying nightly, required by stwo
69-
# (unstable Rust features ).
68+
# starknet_transaction_prover has its own rust-toolchain.toml specifying nightly, required by stwo
69+
# (unstable Rust features).
7070
- name: Ensure nightly toolchain is installed
71-
working-directory: crates/starknet_os_runner
71+
working-directory: crates/starknet_transaction_prover
7272
run: rustup show
7373

7474
- name: Run clippy with all features
75-
working-directory: crates/starknet_os_runner
76-
run: cargo clippy -p starknet_os_runner --no-deps --all-targets --all-features
75+
working-directory: crates/starknet_transaction_prover
76+
run: cargo clippy -p starknet_transaction_prover --no-deps --all-targets --all-features
7777

7878
# Running tests in release mode since stwo significantly slower in debug mode.
7979
- name: Run tests in release mode
80-
working-directory: crates/starknet_os_runner
81-
run: cargo test -p starknet_os_runner --features stwo_proving --release
80+
working-directory: crates/starknet_transaction_prover
81+
run: cargo test -p starknet_transaction_prover --features stwo_proving --release
8282

8383
# Download RPC record fixtures from GCS for ignored integration tests.
8484
- id: auth
8585
uses: "google-github-actions/auth@v2"
8686
with:
8787
credentials_json: ${{ secrets.SA_STARKNET_OS_RUNNER_ARTIFACTS }}
8888
- uses: "google-github-actions/setup-gcloud@v2"
89-
- run: mkdir -p ./crates/starknet_os_runner/resources/rpc_records
90-
- run: gcloud storage cp -r gs://starknet-os-runner-artifacts/rpc_records/* ./crates/starknet_os_runner/resources/rpc_records/
89+
- run: mkdir -p ./crates/starknet_transaction_prover/resources/rpc_records
90+
- run: gcloud storage cp -r gs://starknet-os-runner-artifacts/rpc_records/* ./crates/starknet_transaction_prover/resources/rpc_records/
9191

9292
# Run tests sequentially (no parallelism) since proving is a heavy CPU and memory intensive task
9393
- name: Run proving integration tests
94-
working-directory: crates/starknet_os_runner
95-
run: cargo test --release -p starknet_os_runner --features stwo_proving virtual_snos_prover_test -- --ignored --test-threads=1
94+
working-directory: crates/starknet_transaction_prover
95+
run: cargo test --release -p starknet_transaction_prover --features stwo_proving virtual_snos_prover_test -- --ignored --test-threads=1
9696

97-
# Test that the starknet_os_runner Docker image builds successfully.
97+
# Test that the starknet_transaction_prover Docker image builds successfully.
9898
docker-build:
9999
runs-on: namespace-profile-medium-ubuntu-24-04-amd64
100100
timeout-minutes: 30
@@ -104,11 +104,11 @@ jobs:
104104
- name: Set up Docker Buildx
105105
uses: docker/setup-buildx-action@v3
106106

107-
- name: Build starknet_os_runner Docker image
107+
- name: Build starknet_transaction_prover Docker image
108108
uses: docker/build-push-action@v6.13.0
109109
with:
110110
context: .
111-
file: crates/starknet_os_runner/Dockerfile
111+
file: crates/starknet_transaction_prover/Dockerfile
112112
# Uses debug mode for faster compilation.
113113
build-args: BUILD_MODE=debug
114114
push: false

Cargo.lock

Lines changed: 47 additions & 47 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ members = [
109109
"crates/starknet_committer_cli",
110110
"crates/starknet_os",
111111
"crates/starknet_os_flow_tests",
112-
"crates/starknet_os_runner",
113112
"crates/starknet_patricia",
114113
"crates/starknet_patricia_storage",
114+
"crates/starknet_transaction_prover",
115115
"toml_test_utils",
116116
"workspace_tests",
117117
]
@@ -373,9 +373,9 @@ starknet_committer_and_os_cli.path = "crates/starknet_committer_and_os_cli"
373373
starknet_committer_cli.path = "crates/starknet_committer_cli"
374374
starknet_os.path = "crates/starknet_os"
375375
starknet_os_flow_tests.path = "crates/starknet_os_flow_tests"
376-
starknet_os_runner.path = "crates/starknet_os_runner"
377376
starknet_patricia.path = "crates/starknet_patricia"
378377
starknet_patricia_storage.path = "crates/starknet_patricia_storage"
378+
starknet_transaction_prover.path = "crates/starknet_transaction_prover"
379379
static_assertions = "1.1.0"
380380
strum = "0.27.2"
381381
stwo = "2.1.0"

commitlint.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ const AllowedScopes = ['apollo_base_layer_tests',
113113
'starknet_committer_and_os_cli',
114114
'starknet_os',
115115
'starknet_os_flow_tests',
116-
'starknet_os_runner',
116+
'starknet_transaction_prover',
117117
'starknet_patricia',
118118
'starknet_patricia_storage',
119119
'time',

crates/starknet_os_flow_tests/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ starknet-types-core.workspace = true
2424
starknet_api.workspace = true
2525
starknet_committer = { workspace = true, features = ["testing"] }
2626
starknet_os = { workspace = true, features = ["include_program_output", "testing"] }
27-
starknet_os_runner.workspace = true
2827
starknet_patricia = { workspace = true, features = ["testing"] }
2928
starknet_patricia_storage = { workspace = true, features = ["testing"] }
29+
starknet_transaction_prover.workspace = true
3030
strum.workspace = true
3131
tokio.workspace = true
3232

crates/starknet_os_flow_tests/src/initial_state.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ use starknet_api::{calldata, deploy_account_tx_args, invoke_tx_args};
3535
use starknet_committer::block_committer::input::StateDiff;
3636
use starknet_committer::db::facts_db::FactsDb;
3737
use starknet_committer::db::forest_trait::StorageInitializer;
38-
use starknet_os_runner::running::committer_utils::{
38+
use starknet_patricia_storage::map_storage::MapStorage;
39+
use starknet_transaction_prover::running::committer_utils::{
3940
commit_state_diff,
4041
state_maps_to_committer_state_diff,
4142
};
42-
use starknet_patricia_storage::map_storage::MapStorage;
4343
use starknet_types_core::felt::Felt;
4444

4545
use crate::test_manager::{

crates/starknet_os_flow_tests/src/test_manager.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ use starknet_os::io::os_output_types::{
7171
use starknet_os::io::test_utils::validate_kzg_segment;
7272
use starknet_os::runner::{run_os_stateless, DEFAULT_OS_LAYOUT};
7373
use starknet_os::test_utils::coverage::expect_hint_coverage;
74-
use starknet_os_runner::running::committer_utils::{
74+
use starknet_transaction_prover::running::committer_utils::{
7575
commit_state_diff,
7676
state_maps_to_committer_state_diff,
7777
};

crates/starknet_os_runner/Cargo.toml renamed to crates/starknet_transaction_prover/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
[package]
2-
name = "starknet_os_runner"
2+
name = "starknet_transaction_prover"
33
version.workspace = true
44
edition.workspace = true
55
repository.workspace = true
66
license-file.workspace = true
7-
description = "Runs transactions through the Starknet OS and returns Cairo PIE and OS output."
7+
description = "Standalone service that proves individual Starknet transactions using the virtual Starknet OS and Stwo prover."
88

99
[features]
1010
cairo_native = ["blockifier/cairo_native"]

crates/starknet_os_runner/Dockerfile renamed to crates/starknet_transaction_prover/Dockerfile

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
# crates/starknet_os_runner/Dockerfile
1+
# crates/starknet_transaction_prover/Dockerfile
22
#
3-
# Self-contained Dockerfile for building the starknet_os_runner service.
4-
# This Dockerfile is designed for external parties to build and run the OS runner
3+
# Self-contained Dockerfile for building the starknet_transaction_prover service.
4+
# This Dockerfile is designed for external parties to build and run the tx prover
55
# without requiring the full internal build infrastructure.
66
#
77
# Build:
8-
# docker build -f crates/starknet_os_runner/Dockerfile -t os_runner:latest .
8+
# docker build -f crates/starknet_transaction_prover/Dockerfile -t tx_prover:latest .
99
#
1010
# Run:
11-
# docker run --rm -p 3000:3000 os_runner:latest
11+
# docker run --rm -p 3000:3000 tx_prover:latest
1212
#
1313
# Key differences from the internal Dockerfile (deployments/images/sequencer/Dockerfile):
1414
# - No dockerfile-x INCLUDE directive
@@ -52,7 +52,7 @@ ENV CARGO_HOME=${RUSTUP_HOME}
5252
ENV PATH="${RUSTUP_HOME}/bin:${PATH}"
5353

5454
# Use the crate-level rust-toolchain.toml (nightly).
55-
COPY crates/starknet_os_runner/rust-toolchain.toml rust-toolchain.toml
55+
COPY crates/starknet_transaction_prover/rust-toolchain.toml rust-toolchain.toml
5656

5757
# --default-toolchain none: skip installing the default stable toolchain, since we only need
5858
# the nightly defined in rust-toolchain.toml.
@@ -67,7 +67,7 @@ RUN python3 -m venv ${VIRTUAL_ENV}
6767
ENV PATH="${VIRTUAL_ENV}/bin:${PATH}"
6868

6969
# Install cairo-lang package for cairo-compile tool.
70-
# This is the minimum required for building starknet_os_runner.
70+
# This is the minimum required for building starknet_transaction_prover.
7171
ARG CAIRO_LANG_VERSION=0.14.1a0
7272
RUN pip install --no-cache-dir cairo-lang==${CAIRO_LANG_VERSION}
7373

@@ -77,7 +77,7 @@ RUN pip install --no-cache-dir cairo-lang==${CAIRO_LANG_VERSION}
7777
FROM base AS planner
7878
WORKDIR /app
7979
COPY . .
80-
COPY crates/starknet_os_runner/rust-toolchain.toml rust-toolchain.toml
80+
COPY crates/starknet_transaction_prover/rust-toolchain.toml rust-toolchain.toml
8181
RUN cargo chef prepare --recipe-path recipe.json
8282

8383
# =============================================================================
@@ -98,17 +98,17 @@ RUN if [ "$BUILD_MODE" != "release" ] && [ "$BUILD_MODE" != "debug" ]; then \
9898
fi
9999

100100
# Cache dependencies with cargo-chef.
101-
# Use -p starknet_os_runner to avoid building LLVM-dependent crates (e.g., cairo_native).
101+
# Use -p starknet_transaction_prover to avoid building LLVM-dependent crates (e.g., cairo_native).
102102
COPY --from=planner /app/recipe.json recipe.json
103-
COPY crates/starknet_os_runner/rust-toolchain.toml rust-toolchain.toml
103+
COPY crates/starknet_transaction_prover/rust-toolchain.toml rust-toolchain.toml
104104
RUN BUILD_FLAGS=$([ "$BUILD_MODE" = "release" ] && echo "--release" || true); \
105-
cargo chef cook $BUILD_FLAGS -p starknet_os_runner --features stwo_proving --recipe-path recipe.json
105+
cargo chef cook $BUILD_FLAGS -p starknet_transaction_prover --features stwo_proving --recipe-path recipe.json
106106

107-
# Copy source and build starknet_os_runner (without cairo_native feature).
107+
# Copy source and build starknet_transaction_prover (without cairo_native feature).
108108
COPY . .
109-
COPY crates/starknet_os_runner/rust-toolchain.toml rust-toolchain.toml
109+
COPY crates/starknet_transaction_prover/rust-toolchain.toml rust-toolchain.toml
110110
RUN BUILD_FLAGS=$([ "$BUILD_MODE" = "release" ] && echo "--release" || true); \
111-
cargo build $BUILD_FLAGS -p starknet_os_runner --features stwo_proving
111+
cargo build $BUILD_FLAGS -p starknet_transaction_prover --features stwo_proving
112112

113113
# =============================================================================
114114
# Stage 4: Final runtime image
@@ -127,10 +127,10 @@ ENV ID=1001
127127
WORKDIR /app
128128

129129
# Copy the binary.
130-
COPY --from=builder /app/target/${BUILD_MODE}/starknet_os_runner ./target/${BUILD_MODE}/starknet_os_runner
130+
COPY --from=builder /app/target/${BUILD_MODE}/starknet_transaction_prover ./target/${BUILD_MODE}/starknet_transaction_prover
131131

132132
# Copy resources needed by the service (includes bootloader).
133-
COPY --from=builder /app/crates/starknet_os_runner/resources ./crates/starknet_os_runner/resources
133+
COPY --from=builder /app/crates/starknet_transaction_prover/resources ./crates/starknet_transaction_prover/resources
134134

135135
# Copy starknet-sierra-compile binary required for Sierra to Casm compilation.
136136
COPY --from=builder /app/target/${BUILD_MODE}/shared_executables/starknet-sierra-compile ./target/${BUILD_MODE}/shared_executables/starknet-sierra-compile
@@ -152,4 +152,4 @@ EXPOSE 3000
152152
USER ${ID}
153153

154154
# Use tini as the init process.
155-
ENTRYPOINT ["sh", "-c", "exec tini -- /app/target/$BUILD_MODE/starknet_os_runner \"$@\"", "--"]
155+
ENTRYPOINT ["sh", "-c", "exec tini -- /app/target/$BUILD_MODE/starknet_transaction_prover \"$@\"", "--"]

0 commit comments

Comments
 (0)