fix(ci): properly install python deps, in CI and docker

Author: dorimedini-starkware

.github/actions/bootstrap/action.yml

@@ -19,3 +19,6 @@ runs:
         github_token: ${{ inputs.github_token }}
     - name: Install cairo native.
       uses: ./.github/actions/setup_native_deps
+    - name: Install python requirements.
+      shell: bash
+      run: pip install -r scripts/requirements.txt

.github/workflows/main.yml

@@ -59,11 +59,6 @@ jobs:
           extra_rust_toolchains: ${{ env.EXTRA_RUST_TOOLCHAINS }}
           github_token: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Setup Python venv
-        run: |
-          python3 -m venv ci
-          ci/bin/pip install -r scripts/requirements.txt
-
       # Check Cargo.lock is up to date.
       - name: "Check Cargo.lock"
         run: |
@@ -77,13 +72,13 @@ jobs:
       # Run code style on PR.
       - name: "Run TODO style pull request"
         if: github.event_name == 'pull_request'
-        run: ci/bin/python scripts/named_todos.py --commit_id ${{ github.event.pull_request.base.sha }}
+        run: scripts/named_todos.py --commit_id ${{ github.event.pull_request.base.sha }}
       - name: "Run clippy pull request"
         if: github.event_name == 'pull_request'
-        run: ci/bin/python scripts/run_tests.py --command clippy --changes_only --commit_id ${{ github.event.pull_request.base.sha }}
+        run: scripts/run_tests.py --command clippy --changes_only --commit_id ${{ github.event.pull_request.base.sha }}
       - name: "Run cargo doc pull request"
         if: github.event_name == 'pull_request'
-        run: ci/bin/python scripts/run_tests.py --command doc --changes_only --commit_id ${{ github.event.pull_request.base.sha }}
+        run: scripts/run_tests.py --command doc --changes_only --commit_id ${{ github.event.pull_request.base.sha }}
 
       # Run code style on push.
       - name: "Run rustfmt"
@@ -93,10 +88,10 @@ jobs:
 
       - name: "Run clippy on push"
         if: github.event_name == 'push'
-        run: ci/bin/python scripts/run_tests.py --command clippy
+        run: scripts/run_tests.py --command clippy
       - name: "Run cargo doc on push"
         if: github.event_name == 'push'
-        run: ci/bin/python scripts/run_tests.py --command doc
+        run: scripts/run_tests.py --command doc
 
       - name: "Run taplo"
         run: scripts/taplo.sh
@@ -139,31 +134,25 @@ jobs:
       - name: "Run tests pull request"
         if: github.event_name == 'pull_request'
         run: |
-          python3 -m venv ci
-          ci/bin/pip install -r scripts/requirements.txt
-          ci/bin/python scripts/run_tests.py --command test --changes_only --include_dependencies --commit_id ${{ github.event.pull_request.base.sha }}
+          scripts/run_tests.py --command test --changes_only --include_dependencies --commit_id ${{ github.event.pull_request.base.sha }}
         env:
           SEED: 0
 
       - name: "Run integration tests pull request"
         if: github.event_name == 'pull_request'
         # TODO(Tsabary): Find a better way to set the ephemeral port range.
         run: |
-          python3 -m venv ci
-          ci/bin/pip install -r scripts/requirements.txt
           echo "net.ipv4.ip_local_port_range = 40000 40200" | sudo tee /etc/sysctl.conf
           sudo sysctl -p
-          ci/bin/python scripts/run_tests.py --command integration --changes_only --include_dependencies --commit_id ${{ github.event.pull_request.base.sha }}
+          scripts/run_tests.py --command integration --changes_only --include_dependencies --commit_id ${{ github.event.pull_request.base.sha }}
         env:
           SEED: 0
 
       - name: "Run tests on push"
         if: github.event_name == 'push'
         # TODO(AdiY/Dori): Better support for running tests on push.
         run: |
-          python3 -m venv ci
-          ci/bin/pip install -r scripts/requirements.txt
-          ci/bin/python scripts/run_tests.py --command test
+          scripts/run_tests.py --command test
         env:
           SEED: 0
 

.github/workflows/main_nightly.yml

@@ -50,11 +50,6 @@ jobs:
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Setup Python venv
-        run: |
-          python3 -m venv ci
-          ci/bin/pip install -r scripts/requirements.txt
-
       # Run feature combo test.
       - name: "Run feature combo on all crates."
-        run: ci/bin/python scripts/run_feature_combos_test.py
+        run: scripts/run_feature_combos_test.py

.github/workflows/merge_queue_ci.yml

@@ -33,19 +33,14 @@ jobs:
           extra_rust_toolchains: ${{ env.EXTRA_RUST_TOOLCHAINS }}
           github_token: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Setup Python venv
-        run: |
-          python3 -m venv ci
-          ci/bin/pip install -r scripts/requirements.txt
-
       # Check Cargo.lock is up to date.
       - name: "Check Cargo.lock"
         run: |
           cargo update -w --locked
           git diff --exit-code Cargo.lock
 
       - name: "Run clippy on merge queue"
-        run: ci/bin/python scripts/run_tests.py --command clippy
+        run: scripts/run_tests.py --command clippy
 
       - name: "Run rustfmt on merge queue"
         # The nightly here is coupled with the one in install_rust/action.yml.

scripts/named_todos.py

@@ -1,3 +1,5 @@
+#!/bin/env python3
+
 import os
 import re
 

scripts/requirements.txt

@@ -1,3 +1,4 @@
 cairo-lang==0.13.5
 sympy==1.12.0 # pypy3.9 issue.
 GitPython
+gitpython